Skip to content

Commit 357e422

Browse files
makeavishankitnayanpalashgdev
authored
fix: add support for bool values in time series result (SigNoz#2713)
* fix: add support for bool values in time series result * chore: reserved target column can never be bool so removed obsolete code --------- Co-authored-by: Ankit Nayan <ankit@signoz.io> Co-authored-by: Palash Gupta <palashgdev@gmail.com>
1 parent ca3ff04 commit 357e422

File tree

1 file changed

+6
-2
lines changed
  • pkg/query-service/app/clickhouseReader

1 file changed

+6
-2
lines changed

pkg/query-service/app/clickhouseReader/reader.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -4096,8 +4096,12 @@ func readRow(vars []interface{}, columnNames []string) ([]string, map[string]str
40964096
groupBy = append(groupBy, fmt.Sprintf("%v", reflect.ValueOf(v).Elem().Int()))
40974097
groupAttributes[colName] = fmt.Sprintf("%v", reflect.ValueOf(v).Elem().Int())
40984098
}
4099+
case *bool:
4100+
groupBy = append(groupBy, fmt.Sprintf("%v", *v))
4101+
groupAttributes[colName] = fmt.Sprintf("%v", *v)
4102+
40994103
default:
4100-
zap.S().Errorf("unsupported var type %v found in metric builder query result for column %s", v, colName)
4104+
zap.S().Errorf("unsupported var type %v found in query builder query result for column %s", v, colName)
41014105
}
41024106
}
41034107
return groupBy, groupAttributes, point
@@ -4424,4 +4428,4 @@ func (r *ClickHouseReader) GetSpanAttributeKeys(ctx context.Context) (map[string
44244428
response[tagKey] = key
44254429
}
44264430
return response, nil
4427-
}
4431+
}

0 commit comments

Comments
 (0)