Skip to content

Opening the possibility of injecting a PSR-18 compatible HTTP Client #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2020

Conversation

bbaga
Copy link
Contributor

@bbaga bbaga commented Jun 13, 2020

Using PSR-18 interface instead of hard Guzzle dependency

More context: #32

@bbaga bbaga marked this pull request as ready for review June 13, 2020 14:45
@bbaga
Copy link
Contributor Author

bbaga commented Jun 14, 2020

Small update with a minor change in Client + readme update

@mghoneimy
Copy link
Owner

A few things on this, first of all thank you for the contribution, this was very valuable to improving this package! I'm very happy that we are very close to having the package not dependent on a specific client implementation, when I start working on the new major version upgrade I'll make sure that this is part of it.

Also, I just checked Guzzle's next major version (7.0) will implement the PSR-18 client interface, which will make it much easier to integrate into the package without needing the GuzzleAdapter class. It might be a good time to consider working on the next major version actually when Guzzle's 7.0 is out!

Thank you for contribution to this package, if you don't have anything else you'd like to add I'll merge the pull request tomorrow.

@mghoneimy mghoneimy merged commit 6acb643 into mghoneimy:master Jun 14, 2020
@bbaga
Copy link
Contributor Author

bbaga commented Jun 14, 2020

🎉 🥳 🎉

The Guzzle 7 beta is out for a while now so I hope they'll release the real deal soon! It will be awesome.👏

Thanks for being so quick to respond to questions and the PR, it was really nice working with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants