no-output-on-prefix incorrectly throws error if output property name starts with "one"

[compeek]

I enabled the new no-output-on-prefix rule and started getting an error for an output property named oneTimeScheduleDetailItemChange. It seems the rule is only looking at the first two letters. It should really check the first three and see if the first two are "on" and the third is a capital letter.

I'm using codelyzer 4.0.2 with Angular 5.1.3.

[mgechev]

Good catch. Will add a fix in the next release.

[tatsujb]

I'm currently getting this but with "on"

[lazarljubenovic]

@tatsujb I'm not sure I understand you correctly but if you're getting an error with an output named something like "onClick", then that's the point of the rule: it should be just "click".

[tatsujb]

ok that's dumb. why can't it be "on" when that would allow you to match Angular's naming convention?

like the function I'm trying to hit is the original one, the one you call "click", no prefix. so I can't call the emitter "click" again, vars and functions may only be declared once in JS.

so naturally "onClick" springs up to your mind as the natural name which would allow your own function to follow many if not all of Angular's functions' naming convention.

[lazarljubenovic]

It doesn't: https://angular.io/guide/styleguide#dont-prefix-output-properties

Do name events without the prefix on.

[lazarljubenovic]

If you want to use the on prefix for some reason, simply turn off this lint rule. This one is specifically for forbidding the on prefix, as the name implies: no output "on" prefix.

[tatsujb]

Oh. my bad. so they bridge the "name-gap" html-side :
<toh-hero (savedTheDay)="onSavedTheDay($event)"></toh-hero>

yeah that makes more sense, sorry.

[ghost]

I get the same warning like you, an easy way to fix this is to not use camelCase try to use something like this.

you can set a rule of course http://codelyzer.com/rules/no-output-on-prefix/

or

onReset  <--  warning
onreset  <--  ok