Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue building on New arch #39

Open
projay11 opened this issue Nov 1, 2024 · 0 comments
Open

Issue building on New arch #39

projay11 opened this issue Nov 1, 2024 · 0 comments

Comments

@projay11
Copy link

projay11 commented Nov 1, 2024

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @mgcrea/vision-camera-barcode-scanner@0.11.2 for the project I'm working on.

This fixes an issue building on the new arch

Here is the diff that solved my problem:

diff --git a/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle b/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle
index 5c348ac..e8715e7 100644
--- a/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle
+++ b/node_modules/@mgcrea/vision-camera-barcode-scanner/android/build.gradle
@@ -71,7 +71,7 @@ dependencies {
 
 if (isNewArchitectureEnabled()) {
   react {
-    jsRootDir = file("../src/")
+    jsRootDir = file("../dist/")
     libraryName = "VisionCameraCodeScanner"
     codegenJavaPackageName = "com.visioncameracodescanner"
   }

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant