Check in BizHawk build scripts #3272
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endrift
requested changes
Aug 12, 2024
There was a problem hiding this comment.
You should remove the XCode project if no one is using it. Further, I can already confirm this won't build. I'd like to at least try to make sure the bizinterface DLL builds via CI so I know when I'm gonna be breaking things for you. It looks like the last time this was downstreamed was several months ago, as you reference some files I've removed, so I'd like it if you can get it building again before I merge this.
|
Removed files and dropped one source entry from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes that's all the changes as of
bizhawk-0.11. And I think some of that can be removed still, namely the Xcode project files. The last upstream change to be merged in was cecb454, but I've rebased, so one of the changes since then may have broken the build.How much of this you keep, or drop, or keep with modifications is up to you. The C FFI can be changed slightly too.
re: TASEmulators/BizHawk#2312