Skip to content

Commit 5bc7afb

Browse files
committed
refactor(parameters): Fix some parameters not in array errors
1 parent b7fd8ed commit 5bc7afb

File tree

2 files changed

+65
-63
lines changed

2 files changed

+65
-63
lines changed

surface_reconstruction/open3d_surface.py

Lines changed: 42 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -8,48 +8,50 @@ class Open3dSurface(SurfaceStrategy):
88

99
parameters = {
1010
'estimate_normals': [
11-
{
12-
'name': 'fast_normal_computation',
13-
'description': 'Fast normal estimation',
14-
'value': True
15-
},
16-
{
17-
'name': 'normals',
18-
'description': 'Points normals',
19-
'value': (1, 3)
20-
}
11+
{
12+
'name': 'fast_normal_computation',
13+
'description': 'Fast normal estimation',
14+
'value': True
15+
},
16+
{
17+
'name': 'normals',
18+
'description': 'Points normals',
19+
'value': (1, 3)
20+
}
21+
],
22+
'orient_normals_consistent_tangent_plane': [
23+
{
24+
'name': 'k',
25+
'description': 'Nearest neighbors',
26+
'value': 100
27+
}
2128
],
22-
'orient_normals_consistent_tangent_plane': {
23-
'name': 'k',
24-
'description': 'Nearest neighbors',
25-
'value': 100
26-
},
2729
'surface_reconstruction_screened_poisson': [
28-
{
29-
'name': 'depth',
30-
'description': 'Maximum depth of the tree',
31-
'value': 8
32-
},
33-
{
34-
'name': 'width',
35-
'description': 'Target width',
36-
'value': 0
37-
},
38-
{
39-
'name': 'scale',
40-
'description': 'Ratio between the diameter of the cube',
41-
'value': 1.1
42-
},
43-
{
44-
'name': 'linear_fit',
45-
'description': 'Use linear interpolation?',
46-
'value': False
47-
},
48-
{
49-
'name': 'n_threads',
50-
'description': 'Number of threads used for reconstruction',
51-
'value': -1
52-
}
30+
{
31+
'name': 'depth',
32+
'description': 'Maximum depth of the tree',
33+
'value': 8
34+
},
35+
{
36+
'name': 'width',
37+
'description': 'Target width',
38+
'value': 0
39+
},
40+
{
41+
'name': 'scale',
42+
'description': 'Ratio between the diameter of the cube',
43+
'value': 1.1
44+
},
45+
{
46+
'name': 'linear_fit',
47+
'description': 'Use linear interpolation?',
48+
'value': False
49+
},
50+
{
51+
'name': 'n_threads',
52+
'description': 'Number of threads used for reconstruction',
53+
'value': -1
54+
}
5355
]
5456
}
5557

tests/pymeshlab_test.py

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,30 +8,30 @@
88
class PyMeshlabTest(unittest.TestCase):
99

1010
poisson_parameters = {
11-
'filters': {
12-
'point_cloud_simplification': {
13-
# Best quality: 1000000, Simple/Low quality (default): 1000
14-
'samplenum': 1000000,
15-
},
16-
'compute_normals_for_point_sets': {
17-
'k': 5,
18-
'smoothiter': 0,
19-
'flipflag': False,
20-
'viewpos': [0, 0, 0]
21-
},
22-
'surface_reconstruction_screened_poisson': {
23-
'depth': 8,
24-
'cgdepth': 0,
25-
'fulldepth': 5,
26-
'visiblelayer': False,
27-
'scale': 1.1,
28-
'samplespernode': 1.5,
29-
'pointweight': 4,
30-
'iters': 8,
31-
'confidence': False,
32-
'preclean': False
11+
'filters': {
12+
'point_cloud_simplification': {
13+
# Best quality: 1000000, Simple/Low quality (default): 1000
14+
'samplenum': 1000000
15+
},
16+
'compute_normals_for_point_sets': {
17+
'k': 5,
18+
'smoothiter': 0,
19+
'flipflag': False,
20+
'viewpos': [0, 0, 0]
21+
},
22+
'surface_reconstruction_screened_poisson': {
23+
'depth': 8,
24+
'cgdepth': 0,
25+
'fulldepth': 5,
26+
'visiblelayer': False,
27+
'scale': 1.1,
28+
'samplespernode': 1.5,
29+
'pointweight': 4,
30+
'iters': 8,
31+
'confidence': False,
32+
'preclean': False
33+
}
3334
}
34-
}
3535
}
3636

3737
def setUp(self):

0 commit comments

Comments
 (0)