Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Absolute Image Paths #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joshuafranks
Copy link
Contributor

Description

At present, we references images with relative paths. On the website, this is fine - but if you're trying to view the documentation here on GitHub, it's a bit of a mess. I think we should use absolute paths instead. In the future we may want to consider a CDN, but I don't think there's any need for that at this stage.

@joshuafranks joshuafranks marked this pull request as ready for review June 11, 2020 16:40
@joshuafranks joshuafranks requested a review from JonoB June 11, 2020 16:40
@joshuafranks
Copy link
Contributor Author

Not sure if you can think of any reasons why this would be a bad idea, @JonoB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant