HTTPClientTransport WithClient #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new method, WithClient, on the HTTPClientTransport to allow users to override the default HTTP client used in requests.
- Adds the WithClient method to configure the HTTP client.
- Supports method chaining by returning the modified transport instance.
ecekyn
approved these changes
May 7, 2025
|
Hey @laotoutou, i had to revert this in #114, to merge the custom http client implementation which I have just seen: (#111) Let me know if this doesn't work for you. Thanks for your contribution either way! |
dissoupov
pushed a commit
to effective-security/mcp-golang
that referenced
this pull request
May 16, 2025
dissoupov
pushed a commit
to effective-security/mcp-golang
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.