Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Update to fibers 4.0 for Node 12 compatibility #25

Closed
HachetAmaury opened this issue Mar 18, 2020 · 2 comments · Fixed by #26
Closed

Update to fibers 4.0 for Node 12 compatibility #25

HachetAmaury opened this issue Mar 18, 2020 · 2 comments · Fixed by #26

Comments

@HachetAmaury
Copy link

Now that meteor 1.9.3 use Node 12 meteor-promise should also be updated to support fibers 4.0.0 since it's a fact that fibers 3.1.1 doesn't work with node 12 :

laverdet/node-fibers#409

@aas395
Copy link

aas395 commented Mar 30, 2020

How is this package included with releases 1.9.3 and up if it requires an old version of fibers that doesn't work with node 12? I'm trying to track down a fibers issue I'm having and it looks like I'll run into this once I fix the first one

@ebbe-brandstrup
Copy link

This package doesn't depend on the fibers package directly. It only has a devDependency on fibers to install them for running tests / doing development on meteor-promise itself.

It instead just assumes that the dependent program supplies the Fiber constructor by setting it on Promise.Fiber (like the tests in this repo do:

promise/test/tests.js

Lines 2 to 5 in 1e52f29

var Fiber = require("fibers");
var Promise = require("../promise_server.js");
Promise.Fiber = Fiber;
).

So that's why it still works with Node 12+ (because Meteor installs fibers v4+ and sets Promise.Fiber to that version's constructor).

However, it would still be good to bump the devDependency on fibers in here so tests are executed against the same version of fibers as the latest Meteor release uses.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants