add value kwarg to filter for specific query parameters to remove, fixes interdoc-edit-bot#70

Author: mahmoud

hyperlink/_url.py

@@ -1560,7 +1560,7 @@ def get(self, name):
         """
         return [value for (key, value) in self.query if name == key]
 
-    def remove(self, name):
+    def remove(self, name, value=_UNSET):
         """Make a new :class:`URL` instance with all occurrences of the query
         parameter *name* removed. No exception is raised if the
         parameter is not already set.
@@ -1572,8 +1572,11 @@ def remove(self, name):
             URL: A new :class:`URL` instance with the parameter removed.
 
         """
-        return self.replace(query=((k, v) for (k, v) in self.query
-                                   if k != name))
+        if value is _UNSET:
+            nq = [(k, v) for (k, v) in self.query if k != name]
+        else:
+            nq = [(k, v) for (k, v) in self.query if not (k == name and v == value)]
+        return self.replace(query=nq)
 
 
 EncodedURL = URL  # An alias better describing what the URL really is

hyperlink/test/test_url.py

@@ -535,6 +535,13 @@ def test_queryRemove(self):
             URL.from_text(u"https://example.com/a/b/?bar=2")
         )
 
+        self.assertEqual(
+            url.remove(name=u"foo", value=u"1"),
+            URL.from_text(u"https://example.com/a/b/?bar=2&foo=3")
+        )
+
+
+
     def test_parseEqualSignInParamValue(self):
         """
         Every C{=}-sign after the first in a query parameter is simply included