Open
Conversation
lundibundi
reviewed
Jun 27, 2023
Comment on lines
+2
to
+6
| AuthError: class AuthError extends DomainError { | ||
| static ALREADY_EXISTS() { | ||
| return new AuthError(409, { message: 'User already exists' }); | ||
| } | ||
| static INVALID_CREDENTIALS() { |
Member
There was a problem hiding this comment.
Why not create separate AuthError classes instead?
class AuthError extends DomainError { code: 401 }
class AuthExistsError extends AuthError { code: 409 }
class AuthInvalidCredentialsError extends AuthError { code 400 }
...
it should be simpler to manage and use.
lundibundi
reviewed
Jun 27, 2023
Comment on lines
+17
to
+20
| onError(error) { | ||
| const { ExampleError } = api.example.error; | ||
| // in theory there's no need to trigger onError handler | ||
| if (error instanceof ExampleError) return error; |
Member
There was a problem hiding this comment.
IMO - this should be default behavior of server for DomainErrors with user-error-format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is the correct way of passing the error class between files in API, but this is how in theory error should be used.
The idea is to have one
error.jsfile in each unit, where you can describe expected errors for the whole unit.