Check db startup and pass siginin error code #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundibundi
changed the title
tshemsedinov
reviewed
Apr 7, 2022
| db.pg = new metarhia.metasql.Database(options); | ||
|
|
||
| // Check that we connected successfully. | ||
| await db.pg.query('SELECT now()').catch((err) => { |
Member
There was a problem hiding this comment.
Can we somehow detect connection status without a query?
Member
There was a problem hiding this comment.
To example, we can catch connection errors by manually creating connection using connect method from Pool:
await db.pg.pool.connect().catch((err) => {
....
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check DB connection status during startup
otherwise we will get random
unhandledRejectionor500errors during API calls with errors likePassword authentication failed for userwith a long PG stacktracePass 403 error code in signin