Bubblegum add event log for burn, redeem, and decompress #1115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Test warning
Note there is one warning when running the tests:
This is because the leaf owner is not marked as a Signer in the Anchor account validation struct. It is only checked at runtime because either the leaf owner or the leaf delegate needs to be a signer but not both. This is planned to be fixed when we switch to Kinobi/Umi to generate the JS SDK.
Read API Testing
I tested these event generations with the Read API by running the JS tests in this PR while running the read API locally.
Previously before this PR I would see
decompress
get indexed, but I would NOT seeburn
get indexed properly. I also am fairly confidentredeem
was not indexing properly but did not isolate it. But not indexingredeem
would not result in significant corruption because no key data gets changed byredeem
. However, the sequence number is supposed to be updated so results in slight incorrect asset table.With this PR change in place, when I ran the "transfer and burn" test, I saw it indexed by the Read API, with
compressed
still set to true andburnt
is now set to true:With this PR change in place, when I ran the "redeem and decompress" test, I saw it still indexed by the Read API, with
compressed
set to false (this tests decompress is still working):