Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: half float support #68

Merged
merged 27 commits into from
Sep 3, 2022
Merged

feat: half float support #68

merged 27 commits into from
Sep 3, 2022

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Add half float support.
Resolves #36

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@codecov-commenter
Copy link

Codecov Report

Merging #68 (4b7b977) into main (5242e66) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   62.17%   62.20%   +0.03%     
==========================================
  Files          27       26       -1     
  Lines         986      987       +1     
==========================================
+ Hits          613      614       +1     
  Misses        373      373              
Flag Coverage Δ
unittests 62.20% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/_src/accelerated_op/adam_op.py 74.66% <100.00%> (ø)
torchopt/_src/transform.py 80.22% <100.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@XuehaiPan XuehaiPan added enhancement New feature or request pytorch Something PyTorch related cxx / cuda Something related to the CXX / CUDA extension labels Sep 1, 2022
@XuehaiPan XuehaiPan linked an issue Sep 2, 2022 that may be closed by this pull request
2 tasks
@XuehaiPan XuehaiPan merged commit 39b533a into main Sep 3, 2022
@XuehaiPan XuehaiPan deleted the half-float branch September 3, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx / cuda Something related to the CXX / CUDA extension enhancement New feature or request pytorch Something PyTorch related
Projects
None yet
3 participants