-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: align argument names with PyTorch #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
force-pushed
the
align-pytorch
branch
from
August 25, 2022 16:14
826a7f3
to
b1b44b6
Compare
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 61.20% 60.40% -0.80%
==========================================
Files 27 27
Lines 781 841 +60
==========================================
+ Hits 478 508 +30
- Misses 303 333 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
XuehaiPan
force-pushed
the
align-pytorch
branch
from
August 26, 2022 02:35
3d7dae4
to
4a985ea
Compare
XuehaiPan
force-pushed
the
align-pytorch
branch
from
August 26, 2022 03:21
cd54216
to
a3cb948
Compare
XuehaiPan
force-pushed
the
align-pytorch
branch
from
August 27, 2022 09:52
638e3a6
to
e8bd609
Compare
XuehaiPan
force-pushed
the
align-pytorch
branch
2 times, most recently
from
August 29, 2022 09:23
8bd5101
to
169ee5b
Compare
XuehaiPan
force-pushed
the
align-pytorch
branch
from
August 29, 2022 11:15
169ee5b
to
4c726f2
Compare
XuehaiPan
force-pushed
the
align-pytorch
branch
2 times, most recently
from
August 29, 2022 12:44
a74a8c2
to
7e96e02
Compare
XuehaiPan
force-pushed
the
align-pytorch
branch
from
August 29, 2022 12:53
7e96e02
to
1fded5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213
if this solves the issue #15213Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
(required)make lint
(required)make test
pass. (required)