Add validation to ensure incompatable values arn't used

Web hook to ensure bmh.spec.Online can't be set to False
if disablePowerOff is enabled

Signed-off-by: Derek Higgins <derekh@redhat.com>

Author: derekhiggins

apis/metal3.io/v1alpha1/baremetalhost_validation.go

@@ -67,6 +67,10 @@ func (host *BareMetalHost) validateHost() []error {
 		errs = append(errs, annotationErrors...)
 	}
 
+	if err := validatePowerStatus(host); err != nil {
+		errs = append(errs, err)
+	}
+
 	return errs
 }
 
@@ -350,3 +354,10 @@ func (host *BareMetalHost) validateCrossNamespaceSecretReferences() []error {
 	}
 	return errs
 }
+
+func validatePowerStatus(host *BareMetalHost) error {
+	if host.Spec.DisablePowerOff && !host.Spec.Online {
+		return fmt.Errorf("node can't simultaneously have online set to false and have power off disabled")
+	}
+	return nil
+}

apis/metal3.io/v1alpha1/baremetalhost_validation_test.go

@@ -770,6 +770,26 @@ func TestValidateCreate(t *testing.T) {
 			oldBMH:    nil,
 			wantedErr: "", // Should be valid
 		},
+		{
+			name: "disablePowerOff",
+			newBMH: &BareMetalHost{
+				Spec: BareMetalHostSpec{
+					DisablePowerOff: true,
+					Online:          true,
+				},
+			},
+			wantedErr: "",
+		},
+		{
+			name: "disablePowerOffErr",
+			newBMH: &BareMetalHost{
+				Spec: BareMetalHostSpec{
+					DisablePowerOff: true,
+					Online:          false,
+				},
+			},
+			wantedErr: "node can't simultaneously have online set to false and have power off disabled",
+		},
 	}
 
 	for _, tt := range tests {