Add ipmi_priv_level to driver_info

Add a new parameter to optionaly set the ipmi privilage
level used when connected to BMC's over ipmi, the default
"ADMINISTRATOR" isn't always available (e.g. in ibmcloud).

Author: derekhiggins

docs/api.md

@@ -32,6 +32,9 @@ communicate with them.
 * IPMI
   * `ipmi://<host>:<port>`, an unadorned `<host>:<port>` is also accepted
     and the port is optional, if using the default one (623).
+  * The ipmi privilege level can be set from the default(`ADMINISTRATOR`)
+    to `OPERATOR` with an option URL parameter `privilegelevel`.
+    `ipmi://<host>:<port>?privilegelevel=OPERATOR`
 * Dell iDRAC
   * `idrac://` (or `idrac+http://` to disable TLS).
   * `idrac-virtualmedia://` to use virtual media instead of PXE

pkg/bmc/access_test.go

@@ -678,11 +678,25 @@ func TestDriverInfo(t *testing.T) {
 			Scenario: "ipmi default port",
 			input:    "ipmi://192.168.122.1",
 			expects: map[string]interface{}{
-				"ipmi_port":      ipmiDefaultPort,
-				"ipmi_password":  "",
-				"ipmi_username":  "",
-				"ipmi_address":   "192.168.122.1",
-				"ipmi_verify_ca": false,
+				"ipmi_port":       ipmiDefaultPort,
+				"ipmi_password":   "",
+				"ipmi_username":   "",
+				"ipmi_address":    "192.168.122.1",
+				"ipmi_verify_ca":  false,
+				"ipmi_priv_level": "ADMINISTRATOR",
+			},
+		},
+
+		{
+			Scenario: "ipmi setting privilege level",
+			input:    "ipmi://192.168.122.1?privilegelevel=OPERATOR",
+			expects: map[string]interface{}{
+				"ipmi_port":       ipmiDefaultPort,
+				"ipmi_password":   "",
+				"ipmi_username":   "",
+				"ipmi_address":    "192.168.122.1",
+				"ipmi_verify_ca":  false,
+				"ipmi_priv_level": "OPERATOR",
 			},
 		},
 

pkg/bmc/ipmi.go

@@ -12,11 +12,24 @@ func init() {
 	RegisterFactory("libvirt", newIPMIAccessDetails, []string{})
 }
 
+func getPrivilegeLevel(rawquery string) string {
+	privilegelevel := "ADMINISTRATOR"
+	q, err := url.ParseQuery(rawquery)
+	if err != nil {
+		return privilegelevel
+	}
+	if val, ok := q["privilegelevel"]; ok {
+		return val[0]
+	}
+	return privilegelevel
+}
+
 func newIPMIAccessDetails(parsedURL *url.URL, disableCertificateVerification bool) (AccessDetails, error) {
 	return &ipmiAccessDetails{
 		bmcType:                        parsedURL.Scheme,
 		portNum:                        parsedURL.Port(),
 		hostname:                       parsedURL.Hostname(),
+		privilegelevel:                 getPrivilegeLevel(parsedURL.RawQuery),
 		disableCertificateVerification: disableCertificateVerification,
 	}, nil
 }
@@ -25,6 +38,7 @@ type ipmiAccessDetails struct {
 	bmcType                        string
 	portNum                        string
 	hostname                       string
+	privilegelevel                 string
 	disableCertificateVerification bool
 }
 
@@ -61,10 +75,11 @@ func (a *ipmiAccessDetails) DisableCertificateVerification() bool {
 // the kernel and ramdisk locations).
 func (a *ipmiAccessDetails) DriverInfo(bmcCreds Credentials) map[string]interface{} {
 	result := map[string]interface{}{
-		"ipmi_port":     a.portNum,
-		"ipmi_username": bmcCreds.Username,
-		"ipmi_password": bmcCreds.Password,
-		"ipmi_address":  a.hostname,
+		"ipmi_port":       a.portNum,
+		"ipmi_username":   bmcCreds.Username,
+		"ipmi_password":   bmcCreds.Password,
+		"ipmi_address":    a.hostname,
+		"ipmi_priv_level": a.privilegelevel,
 	}
 
 	if a.disableCertificateVerification {