-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds option sliderTagName to allow for specifiying HTML element of the slide wrapper #687
base: master
Are you sure you want to change the base?
Conversation
…e used as the slider wrapper HTML (such as 'ul' for a slider of 'li's to maintain valid HTML)
Thanks for opening this PR. It's a neat addition, but I'm not sure how useful it is. The slider is not necessarily a good list item, as there is only ever one of them in the Flickity instance. Anyways, I'll keep this PR open for a bit to see if there's any other interest. |
@desandro My intention was for the slider to be a On a site I'm working on we're displaying trending articles in a Flickity slider. Having the slide wrapper be an
|
ah! right, thanks for clearing that up. Yeah, that semantically makes sense. |
Was this ever added as an option to Flickity? |
I agree - I would love to see this feature get merged in. I have a component that I am building that has somewhat painted me in a corner as far as needing to use |
I ran into an issue where I wanted the individual slider items to be
<li>
s, but the.flickity-slider
is set to be a<div>
with no option to change it. I needed.flickity-slider
to be a<ul>
for valid HTML.This PR introduces the option
sliderTagName
to pass the tagName you want to use for your.flickity-slider
so you can use any tagName you want.