Skip to content

Conversation

@katauber
Copy link
Member

New Xtext project with copy of flux grammar file to provide a language server, which is used for a VS Code/Codium Extension.

@fsteeg
Copy link
Member

fsteeg commented Nov 23, 2020

Nice, this looks good in codium! With the syntax coloring for comments, operators etc.

Noticed one minor thing: .checkstyle contains a machine-specific path. In the root, I don't think we actually need that file at all (the Eclipse Checkstyle plugin should pick up the config using the project-specific file like org.metafacture.flux.ide/.checkstyle, which uses a relative path).

As in metafacture-fix, we should also generate Java sources instead of Xtend. I was thinking of opening a separate issue for that, but maybe it makes sense to do that here, before checking in any Xtend sources in the first place. See metafacture/metafacture-fix@7b8863d for the setup and metafacture/metafacture-fix@4be8950 for the resulting code changes in metafacture-fix.

@katauber katauber assigned fsteeg and unassigned katauber Nov 24, 2020
@katauber
Copy link
Member Author

Thank you for the feedback. I deleted the checkstyle file in the root and I changed to Java resources instead of XTend resources.

@katauber katauber force-pushed the 21-flux-vscode-extension branch from 2fab6c0 to 7afa377 Compare November 25, 2020 10:08
@katauber katauber requested a review from fsteeg November 25, 2020 12:49
@fsteeg
Copy link
Member

fsteeg commented Nov 25, 2020

Great, thanks. Merging, will assign metafacture/metafacture-fix#21 for functional review.

@fsteeg fsteeg merged commit 7f97292 into main Nov 25, 2020
@katauber katauber deleted the 21-flux-vscode-extension branch December 2, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants