Move more autocomplete logic from web to api, fixes #257

Author: monken

lib/MetaCPAN/Document/File.pm

@@ -901,4 +901,37 @@ sub history {
     return $search->sort([{ "file.date" => "desc"}]);
 }
 
+sub _not_rogue {
+    my @rogue_dists = map { { term => { 'file.distribution' => $_ } } } @ROGUE_DISTRIBUTIONS;
+    return { not => { filter => { or => \@rogue_dists } } };
+}
+
+sub autocomplete {
+    my ($self, @terms) = @_;
+    my $query = join(" ", @terms);
+    return $self unless $query;
+    $query =~ s/::/ /g;
+    my @query  = split( /\s+/, $query );
+    my $should = [
+        map {
+            { field     => { 'documentation.analyzed'  => "$_*" } },
+                { field => { 'documentation.camelcase' => "$_*" } }
+            } grep {$_} @query
+    ];
+    return $self->query({
+        custom_score => {
+            query => { bool => { should => $should } },
+            script => "_score - doc['documentation'].stringValue.length()/100",
+        }
+    })->filter({
+        and => [
+            $self->_not_rogue,
+            { exists => { field => 'documentation' } },
+            { term   => { 'file.indexed' => \1 } },
+            { term   => { 'file.authorized' => \1 } },
+            { term => { 'file.status'  => 'latest' } },
+        ]
+    });
+}
+
 __PACKAGE__->meta->make_immutable;

lib/MetaCPAN/Server/Controller/Search/Autocomplete.pm

@@ -5,15 +5,10 @@ with 'MetaCPAN::Server::Role::JSONP';
 
 has '+type' => ( default => 'file' );
 
-sub get : Chained('/search/index') : PathPart('autocomplete') : Args(0) :
-    ActionClass('Deserialize') {
+sub get : Local : Path('') : Args(0) {
     my ( $self, $c ) = @_;
-    my $frac = join( ' ', $c->req->param('q') );
-    my $size = $c->req->params->{size};
-    $size = 20 unless(defined $size);
-    $c->detach('/not_allowed') unless($size =~ /^\d+$/ && $size >= 0 && $size <= 100);
-    my $data = $c->model('CPAN::File')->prefix($frac)->inflate(0)
-        ->fields( [qw(documentation release author distribution)] )->size($size);
+    my $data = $c->model('CPAN::File')->autocomplete($c->req->param("q"))->raw
+        ->fields( [qw(documentation release author distribution)] );
     $c->stash($data->all);
 }