Create info/ Module (Core Query Layer)
#208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support .ndjson.gz (gzip compressed) files - Support .bin.ndjson (gzip member concatenation) files - Add _is_gzip_file() helper function - Add test using existing .ndjson.gz test file
- Create tritonparse/info/ module with kernel_query.py - Implement list_kernels() to list all kernels with launch counts - Implement find_launch_index_by_kernel() to find launch events by kernel name and launch ID - Add KernelSummary and LaunchInfo dataclasses - Add 6 unit tests in TestTritonparseCPU class - Tests use real data from example_output when possible, mock data otherwise This is PR3 from the design doc, providing the foundation for PR4 (reproduce --kernel/--launch-id).
meta-cla
bot
added
the
CLA Signed
- Moved the import of `find_launch_index_by_kernel` to the correct location in `tritonparse/info/__init__.py`. - Removed an unnecessary empty line in `tritonparse/info/kernel_query.py`. This change improves code organization and maintains clarity in the module's interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates the
info/module as the core query layer for kernel information from NDJSON trace files. This is an internal infrastructure PR that will be used by PR4 (reproduce--kernel/--launch-id) and PR5 (info CLI).Changes
tritonparse/info/__init__.py: Module initialization, exports core functionstritonparse/info/kernel_query.py: Core query functions:KernelSummarydataclass: kernel name, hash, total launchesLaunchInfodataclass: launch ID, line index, grid (for PR5)list_kernels(events): List all kernels with their launch countsfind_launch_index_by_kernel(events, kernel_name, launch_id): Find 0-based line index for a kernel's N-th launchtests/test_tritonparse.py: Added 6 unit tests inTestTritonparseCPU:test_list_kernels_empty(): Empty events listtest_list_kernels_single(): Single kernel with multiple launchestest_list_kernels_multiple(): Multiple different kernelstest_find_launch_index_valid(): Valid kernel name and launch_idtest_find_launch_index_kernel_not_found(): Raises ValueError when kernel not foundtest_find_launch_index_out_of_range(): Raises ValueError with valid range hintTesting
Tests use real data from
tests/example_output/parsed_output_complex/dedicated_log_triton_trace_findhao__mapped.ndjson.gzwhen possible, mock data for edge cases (empty list, non-existent kernel, out-of-range launch_id).Notes