remove device mesh #289
Closed
remove device mesh #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86466239. |
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Nov 6, 2025
Summary: Pull Request resolved: meta-pytorch#289 Differential Revision: D86466239
tushar00jain
force-pushed
the
export-D86466239
branch
from
1d31a05 to
1feb3f3
Compare
Summary: Remove device mesh since we don't really use it. Device mesh is undergoing a lot of changes and using private api's makes the subclass difficult to maintain. We will revisit device mesh integration with public api's. Differential Revision: D86466239
tushar00jain
force-pushed
the
export-D86466239
branch
from
1feb3f3 to
3f425b8
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Nov 7, 2025
Summary: Remove device mesh since we don't really use it. Device mesh is undergoing a lot of changes and using private api's makes the subclass difficult to maintain. We will revisit device mesh integration with public api's. Differential Revision: D86466239
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Nov 7, 2025
Summary: Remove device mesh since we don't really use it. Device mesh is undergoing a lot of changes and using private api's makes the subclass difficult to maintain. We will revisit device mesh integration with public api's. Differential Revision: D86466239
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Nov 7, 2025
Summary: Remove device mesh since we don't really use it. Device mesh is undergoing a lot of changes and using private api's makes the subclass difficult to maintain. We will revisit device mesh integration with public api's. Reviewed By: d4l3k Differential Revision: D86466239
|
This pull request has been merged in 8ef24c0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D86466239