handle exception waiting for work #287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@tushar00jain has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84880993. |
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 17, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 17, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
1abde63 to
80d2d98
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 17, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 17, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
80d2d98 to
6b347d0
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 17, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
6b347d0 to
4cb7ac6
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
4cb7ac6 to
e2e52d7
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
e2e52d7 to
01def11
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
01def11 to
bfe2d27
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
bfe2d27 to
f6aee08
Compare
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
f6aee08 to
1ff8642
Compare
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
added a commit
to tushar00jain/torchft
that referenced
this pull request
Oct 21, 2025
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail Reviewed By: d4l3k Differential Revision: D84880993
tushar00jain
force-pushed
the
export-D84880993
branch
from
1ff8642 to
18278ef
Compare
|
This pull request has been merged in 73dafea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: work.wait() can throw so wrap that in a try/catch to handle it gracefully by reporting error to the manager, leading the should_commit to fail
Differential Revision: D84880993