-
Notifications
You must be signed in to change notification settings - Fork 450
Update documentation and error handling for inter-point constraints #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation and error handling for inter-point constraints #3003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
I did not add any tests, but would be happy to turn that example into a dedicated test if being pointed to the correct place for doing so.
It would be great if you could add a lightweight test_error_on_interpoint_constraints() test to TestOptimizeAcqfMixed here https://github.com/pytorch/botorch/blob/main/test/optim/test_optimize.py#L1765 to validate that the error gets raised when passing in inter-point constraints.
Co-authored-by: Max Balandat <Balandat@users.noreply.github.com>
Co-authored-by: Max Balandat <Balandat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 216 216
Lines 20392 20401 +9
=========================================
+ Hits 20392 20401 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
This PR improves the documentation and error handling when attempting to use inter-point constraints within
optimize_acqf_mixedwhich is not supported. It implements the solution to #2996 discussed in this issue.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
I verified my code by ensuring that the example posted in #2996 raises an error message. I did not add any tests, but would be happy to turn that example into a dedicated test if being pointed to the correct place for doing so.
EDIT: A minimal test has been added in 92140e9
Related PRs
None.