Allow batched fixed features in gen_candidates_scipy and gen_candidates_torch
#2893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77043260 |
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 25, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
890115c to
f273a2e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77043260 |
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 25, 2025
…dates_torch` (meta-pytorch#2893) Summary: Pull Request resolved: meta-pytorch#2893 This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
f273a2e to
d5e40db
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 25, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
d5e40db to
996d52a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77043260 |
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 25, 2025
…dates_torch` (meta-pytorch#2893) Summary: Pull Request resolved: meta-pytorch#2893 This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
996d52a to
952720b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 212
Lines 19778 19794 +16
=========================================
+ Hits 19778 19794 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 25, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 25, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 25, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 27, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 27, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 27, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 27, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jun 27, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
952720b to
d2a188d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77043260 |
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: Pull Request resolved: meta-pytorch#2893 This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
d2a188d to
5fa64d4
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
5fa64d4 to
1038467
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77043260 |
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
1038467 to
75623ed
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
|
This pull request was exported from Phabricator. Differential Revision: D77043260 |
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: Pull Request resolved: meta-pytorch#2893 This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
75623ed to
47e6034
Compare
SamuelGabriel
added a commit
to SamuelGabriel/botorch
that referenced
this pull request
Jul 2, 2025
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
…dates_torch` (meta-pytorch#2893) Summary: This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations. We do this by allowing passing tensors of shape [b] or [b,q] to `gen_candidates_scipy` and for `gen_candidates_torch` for compatibility. Reviewed By: saitcakmak Differential Revision: D77043260
SamuelGabriel
force-pushed
the
export-D77043260
branch
from
47e6034 to
f029193
Compare
|
This pull request was exported from Phabricator. Differential Revision: D77043260 |
|
This pull request has been merged in 78de86d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a PR that should enable batching for mixed optimization later. To enable it, we need to allow setting different fixed features for different initial conditions during optimizations.
We do this by allowing passing tensors of shape [b] or [b,q] to
gen_candidates_scipyand forgen_candidates_torchfor compatibility.Differential Revision: D77043260