Implement qLogNParEGO #2364
Closed
Implement qLogNParEGO #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58122015 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 5, 2024
Summary: Adds an implementation of qLogNParEGO that is compatible with Ax MBM. This constructs the Chebyshev scalarization before deferring to qLogNEI for remaining computations. The construction of the Chebyshev objective mirrors what was done in `_get_acqusition_func` for the legacy Ax model. Differential Revision: D58122015
saitcakmak
force-pushed
the
export-D58122015
branch
from
6be1828 to
8c93744
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58122015 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 5, 2024
Summary: Adds an implementation of qLogNParEGO that is compatible with Ax MBM. This constructs the Chebyshev scalarization before deferring to qLogNEI for remaining computations. The construction of the Chebyshev objective mirrors what was done in `_get_acqusition_func` for the legacy Ax model. Differential Revision: D58122015
saitcakmak
force-pushed
the
export-D58122015
branch
from
8c93744 to
58a13cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58122015 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Jun 5, 2024
Summary: Adds an implementation of qLogNParEGO that is compatible with Ax MBM. This constructs the Chebyshev scalarization before deferring to qLogNEI for remaining computations. The construction of the Chebyshev objective mirrors what was done in `_get_acqusition_func` for the legacy Ax model. Differential Revision: D58122015
saitcakmak
force-pushed
the
export-D58122015
branch
from
58a13cf to
43a19fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58122015 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 189 190 +1
Lines 16552 16587 +35
=======================================
+ Hits 16549 16584 +35
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Summary: Adds an implementation of qLogNParEGO that is compatible with Ax MBM. This constructs the Chebyshev scalarization before deferring to qLogNEI for remaining computations. The construction of the Chebyshev objective mirrors what was done in `_get_acqusition_func` for the legacy Ax model. Reviewed By: SebastianAment Differential Revision: D58122015
saitcakmak
force-pushed
the
export-D58122015
branch
from
43a19fe to
e20e2f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58122015 |
|
This pull request has been merged in 8f25f5b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds an implementation of qLogNParEGO that is compatible with Ax MBM. This constructs the Chebyshev scalarization before deferring to qLogNEI for remaining computations. The construction of the Chebyshev objective mirrors what was done in
_get_acqusition_funcfor the legacy Ax model.Differential Revision: D58122015