Skip to content

Commit c1b73b8

Browse files
Balandatfacebook-github-bot
authored andcommitted
Unpin numpy from <2.0 (#2459)
Summary: This unpins numpy from <2.0, which was done as a temporary workaround in #2382 to avoid issues with windows builds. The underlying issue was an incompatibility between pytorch 2.4.0 windows builds and numpy 2.0. Pointed pip to the updated pytorch pip index to pick up newer 2.5.0 dev versions to resolve the issue: #2459 (comment) There is still the issue of existing torch release windows binaries potentially not being compatible with numpy 2.0, but that shouldn't be something that we need to handle. Pull Request resolved: #2459 Reviewed By: esantorella Differential Revision: D60735276 Pulled By: Balandat fbshipit-source-id: 5af618222a6ad8acbedfecc3a7ca4f8a6b45d098
1 parent e44280e commit c1b73b8

File tree

8 files changed

+3
-13
lines changed

8 files changed

+3
-13
lines changed

.github/workflows/deploy_on_release.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ jobs:
6262
run: |
6363
# avoid conda bug in >=23.10.0: https://github.com/conda/conda/issues/13412
6464
conda config --set solver classic
65-
# avoid issues with numpy 2.0 on windows builds and in tensorboard
66-
conda install -y "numpy<2.0"
6765
conda install -y setuptools_scm conda-build conda-verify anaconda-client
6866
conda install -y scipy sphinx pytest flake8 multipledispatch
6967
conda install -y -c pytorch pytorch cpuonly

.github/workflows/nightly.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
env:
3333
ALLOW_LATEST_GPYTORCH_LINOP: true
3434
run: |
35-
pip install --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
35+
pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
3636
pip install git+https://github.com/cornellius-gp/linear_operator.git
3737
pip install git+https://github.com/cornellius-gp/gpytorch.git
3838
pip install .[test]
@@ -81,8 +81,6 @@ jobs:
8181
run: |
8282
# avoid conda bug in >=23.10.0: https://github.com/conda/conda/issues/13412
8383
conda config --set solver classic
84-
# avoid issues with numpy 2.0 on windows builds and in tensorboard
85-
conda install -y "numpy<2.0"
8684
conda install -y scipy multipledispatch setuptools_scm conda-build conda-verify
8785
conda config --set anaconda_upload no
8886
conda install -y -c pytorch-nightly pytorch cpuonly

.github/workflows/reusable_test_pip.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
env:
3737
ALLOW_LATEST_GPYTORCH_LINOP: true
3838
run: |
39-
pip install --pre torch -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
39+
pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
4040
pip install git+https://github.com/cornellius-gp/linear_operator.git
4141
pip install git+https://github.com/cornellius-gp/gpytorch.git
4242
pip install .[test]

.github/workflows/reusable_tutorials.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- if: ${{ !inputs.use_stable_pytorch_gpytorch }}
4444
name: Install latest PyTorch & GPyTorch
4545
run: |
46-
pip install torch torchvision -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
46+
pip install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cpu
4747
pip install git+https://github.com/cornellius-gp/linear_operator.git
4848
pip install git+https://github.com/cornellius-gp/gpytorch.git
4949
- if: ${{ inputs.use_stable_pytorch_gpytorch }}

.github/workflows/test.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ jobs:
3838
run: |
3939
# avoid conda bug in >=23.10.0: https://github.com/conda/conda/issues/13412
4040
conda config --set solver classic
41-
# avoid issues with numpy 2.0 on windows builds and in tensorboard
42-
conda install -y "numpy<2.0"
4341
conda install pytorch torchvision -c pytorch
4442
conda install -y pip scipy sphinx pytest flake8
4543
pip install git+https://github.com/cornellius-gp/linear_operator.git

.github/workflows/test_stable.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ jobs:
3333
run: |
3434
# avoid conda bug in >=23.10.0: https://github.com/conda/conda/issues/13412
3535
conda config --set solver classic
36-
# avoid issues with numpy 2.0 on windows builds and in tensorboard
37-
conda install -y "numpy<2.0"
3836
conda install -y -c pytorch pytorch cpuonly
3937
conda install -y pip scipy pytest
4038
conda install -y -c gpytorch gpytorch

environment.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ dependencies:
1010
- scipy
1111
- multipledispatch
1212
- pyro-ppl>=1.8.4
13-
- numpy<2.0

requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,3 @@ torch>=1.13.1
55
pyro-ppl>=1.8.4
66
gpytorch==1.12
77
linear_operator==0.5.2
8-
numpy<2.0

0 commit comments

Comments
 (0)