Don't allow unused keyword arguments in Model.construct_inputs

Summary: BoTorch changes to go with the subsequent Ax diff. This will eventually need to be landed with this diff going before the Ax diff.

Differential Revision: D53086323

Author: esantorella

botorch/models/model.py

@@ -187,15 +187,13 @@ def condition_on_observations(self, X: Tensor, Y: Tensor, **kwargs: Any) -> Mode
     def construct_inputs(
         cls,
         training_data: SupervisedDataset,
-        **kwargs: Any,
     ) -> Dict[str, Union[BotorchContainer, Tensor]]:
         """
         Construct `Model` keyword arguments from a `SupervisedDataset`.
 
         Args:
             training_data: A `SupervisedDataset`, with attributes `train_X`,
                 `train_Y`, and, optionally, `train_Yvar`.
-            kwargs: Ignored.
 
         Returns:
             A dict of keyword arguments that can be used to initialize a `Model`,

botorch/models/multitask.py

@@ -277,7 +277,6 @@ def construct_inputs(
         task_covar_prior: Optional[Prior] = None,
         prior_config: Optional[dict] = None,
         rank: Optional[int] = None,
-        **kwargs,
     ) -> Dict[str, Any]:
         r"""Construct `Model` keyword arguments from a dataset and other args.
 
@@ -310,9 +309,8 @@ def construct_inputs(
                 raise ValueError(f"eta must be a real number, your eta was {eta}.")
             task_covar_prior = LKJCovariancePrior(num_tasks, eta, sd_prior)
 
-        base_inputs = super().construct_inputs(
-            training_data=training_data, task_feature=task_feature, **kwargs
-        )
+        # Call Model.construct_inputs to parse training data
+        base_inputs = super().construct_inputs(training_data=training_data)
         return {
             **base_inputs,
             "task_feature": task_feature,

botorch/models/pairwise_gp.py

@@ -788,15 +788,13 @@ def batch_shape(self) -> torch.Size:
     def construct_inputs(
         cls,
         training_data: SupervisedDataset,
-        **kwargs: Any,
     ) -> Dict[str, Tensor]:
         r"""
         Construct `Model` keyword arguments from a `RankingDataset`.
 
         Args:
             training_data: A `RankingDataset`, with attributes `train_X`,
                 `train_Y`, and, optionally, `train_Yvar`.
-            kwargs: Ignored.
 
         Returns:
             A dict of keyword arguments that can be used to initialize a