Skip to content

ell: Add new wrap for ell#2646

Draft
hadess wants to merge 1 commit intomesonbuild:masterfrom
hadess:wip/hadess/add-ell
Draft

ell: Add new wrap for ell#2646
hadess wants to merge 1 commit intomesonbuild:masterfrom
hadess:wip/hadess/add-ell

Conversation

@hadess
Copy link

@hadess hadess commented Feb 11, 2026

@hadess hadess force-pushed the wip/hadess/add-ell branch 3 times, most recently from 09ed0d7 to 4e7a930 Compare February 11, 2026 13:29
@hadess
Copy link
Author

hadess commented Feb 11, 2026

I apparently need to find replacements for 2 shell scripts that are used to work-around meson limitations:

@hadess hadess marked this pull request as draft February 11, 2026 13:41
@hadess hadess force-pushed the wip/hadess/add-ell branch 9 times, most recently from b6698d8 to d7f2c7f Compare February 11, 2026 15:02
@hadess hadess force-pushed the wip/hadess/add-ell branch from d7f2c7f to c9edda7 Compare February 11, 2026 15:06
@eli-schwartz
Copy link
Member

eli-schwartz commented Feb 11, 2026

Edit: ah, the remaining failures aren't actually because of this, sorry. My bad. :P

I apparently need to find replacements for 2 shell scripts that are used to work-around meson limitations:

* [gen-cert-expired-pem.sh](https://github.com/hadess/ell/blob/wip/hadess/ell-0.82-add-meson/unit/gen-cert-expired-pem.sh) (used in [unit/meson.build](https://github.com/hadess/ell/blob/wip/hadess/ell-0.82-add-meson/unit/meson.build#L345-L350))

* [xxd.sh](https://github.com/hadess/ell/blob/wip/hadess/ell-0.82-add-meson/unit/xxd.sh) (used in [unit/meson.build](https://github.com/hadess/ell/blob/wip/hadess/ell-0.82-add-meson/unit/meson.build#L414-L422))

Per my advice on IRC, the latest version of this PR uses capture/feed in meson to avoid creating the xxd wrapper script.

The remaining script can be whitelisted here:

PER_PROJECT_PERMITTED_FILES: dict[str, set[str]] = {

It is reasonable to whitelist -- it is being used by the build system, it's not trying to replace upstream sources or anything.

@hadess
Copy link
Author

hadess commented Feb 11, 2026

Edit: ah, the remaining failures aren't actually because of this, sorry. My bad. :P

Yes, we've managed to proceed further, we're now at the point where some of the tests will only pass if a specific kernel module is loaded:
https://patchwork.kernel.org/project/ell/patch/20260211164200.3968281-1-hadess@hadess.net/

I guess I will have to wait for this patch to be merged upstream, and in a release before I can proceed with this wrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants