Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whats the state of cmake_args? #14009

Open
Jan200101 opened this issue Dec 15, 2024 · 1 comment
Open

whats the state of cmake_args? #14009

Jan200101 opened this issue Dec 15, 2024 · 1 comment
Labels
dependency:cmake Issues related to `dependency` with the `cmake` method

Comments

@Jan200101
Copy link
Contributor

to quickly describe cmake_args (since documentation is poor on it):
its an extra parameter of the dependency method that allows specifying cmake arguments for cmake modules only (it will not be used for cmake subprojects)

Currently this parameter appears to be used by only 4 projects on github, has no test cases has no documentation besides a 1 line note on the dependencies page and an inclusion in the 0.50.0 release notes

Further more the function that parses the flag check_cmake_args has this TODO above it:

# TODO: this function will become obsolete once the `cmake_args` kwarg is dropped

and an invocation of it that includes this comment:

# TODO: drop this check once the deprecated `cmake_args` kwarg is removed
extra_cmake_options = check_cmake_args(extra_cmake_options)

I couldn't find anything that mentions the parameter being deprecated (besides the line itself) and there is no logging or version check in the code that announces its deprecation or prevents its use in newer meson projects

@dcbaker
Copy link
Member

dcbaker commented Dec 15, 2024

I saw this too when I was working on my PR to port the dependency() keyword arguments to the typed_kwargs framework. I coulnd't find much in git history about it either, so whatever the plan was it seems like it was in Daniel's head, and not recorded. I would be in favor of dropping the comment unless someone has a good plan for how/why it should be removed.

@dcbaker dcbaker added the dependency:cmake Issues related to `dependency` with the `cmake` method label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency:cmake Issues related to `dependency` with the `cmake` method
Projects
None yet
Development

No branches or pull requests

2 participants