Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle in CMake inputs/dependencies detected with libavif subproject #13602

Open
Teselka opened this issue Aug 26, 2024 · 2 comments
Open

Cycle in CMake inputs/dependencies detected with libavif subproject #13602

Teselka opened this issue Aug 26, 2024 · 2 comments
Labels
bug module:cmake Issues related to the cmake module, including cmake.subproject

Comments

@Teselka
Copy link

Teselka commented Aug 26, 2024

Describe the bug
When trying to build libavif 1.1.1 as subproject meson fails with an error.
meson-log.txt

To Reproduce
Clone libavif into the subprojects dir and run meson setup build
test_libavif.zip

Expected behavior
Normal build setup

system parameters

  • Is this a cross build or just a plain native build (for the same computer)?
    native
  • what operating system (e.g. MacOS Catalina, Windows 10, CentOS 8.0, Ubuntu 18.04, etc.)
    Windows 10
  • what Python version are you using e.g. 3.8.0
    Python 3.7.9
  • what meson --version
    1.5.0
  • what ninja --version if it's a Ninja build
    1.12.1
@dcbaker dcbaker added the module:cmake Issues related to the cmake module, including cmake.subproject label Aug 26, 2024
@dcbaker
Copy link
Member

dcbaker commented Aug 26, 2024

I can reproduce this on Linux, so it doesn't appear to be Windows specific. I haven't looked into it further, but it seems from the updated error message in the linked PR that this is a bug on our end.

@dcbaker dcbaker added the bug label Aug 26, 2024
@dcbaker
Copy link
Member

dcbaker commented Aug 26, 2024

This is actually happening in the svc-src sub-subprojct (Yay for CMake's non-standard subprojects :/), and is (I think) caused by us not handling BYPRODUCTS, which means that we end up treating a command line arguments that has the output, as if it's an input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module:cmake Issues related to the cmake module, including cmake.subproject
Projects
None yet
Development

No branches or pull requests

7 participants
@dcbaker @Teselka and others