Switch to NullLogger for InMemory repository implementations

Replaced Fabric::getLogger with Psr\Log\NullLogger in multiple InMemory repository implementations for consistent logging behavior in unit tests. Adjusted test suite configuration to display warnings.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>

Author: mesilov

Makefile

@@ -10,7 +10,7 @@ lint-rector-fix:
 	vendor/bin/rector process
 
 test-unit:
-	vendor/bin/phpunit --testsuite unit_tests
+	vendor/bin/phpunit --testsuite unit_tests --display-warnings
 
 # integration tests with granularity by api-scope
 test-integration-scope-telephony:

tests/Unit/Application/Contracts/ApplicationInstallations/Repository/InMemoryApplicationInstallationRepositoryImplementationTest.php

@@ -14,6 +14,7 @@
 use Bitrix24\SDK\Tests\Unit\Application\Contracts\ApplicationInstallations\Entity\ApplicationInstallationReferenceEntityImplementation;
 use Carbon\CarbonImmutable;
 use PHPUnit\Framework\Attributes\CoversClass;
+use Psr\Log\NullLogger;
 use Symfony\Component\Uid\Uuid;
 
 #[CoversClass(ApplicationInstallationRepositoryInterface::class)]
@@ -39,6 +40,6 @@ protected function createApplicationInstallationImplementation(Uuid $uuid, Appli
 
     protected function createApplicationInstallationRepositoryImplementation(): ApplicationInstallationRepositoryInterface
     {
-        return new InMemoryApplicationInstallationRepositoryImplementation(Fabric::getLogger());
+        return new InMemoryApplicationInstallationRepositoryImplementation(new NullLogger());
     }
 }

tests/Unit/Application/Contracts/Bitrix24Accounts/Repository/InMemoryBitrix24AccountRepositoryImplementationTest.php

@@ -14,6 +14,7 @@
 use Bitrix24\SDK\Tests\Unit\Application\Contracts\Bitrix24Accounts\Entity\Bitrix24AccountReferenceEntityImplementation;
 use Carbon\CarbonImmutable;
 use PHPUnit\Framework\Attributes\CoversClass;
+use Psr\Log\NullLogger;
 use Symfony\Component\Uid\Uuid;
 
 #[CoversClass(Bitrix24AccountRepositoryInterface::class)]
@@ -50,6 +51,6 @@ protected function createBitrix24AccountImplementation(
 
     protected function createBitrix24AccountRepositoryImplementation(): Bitrix24AccountRepositoryInterface
     {
-        return new InMemoryBitrix24AccountRepositoryImplementation(Fabric::getLogger());
+        return new InMemoryBitrix24AccountRepositoryImplementation(new NullLogger());
     }
 }

tests/Unit/Application/Contracts/Bitrix24Partners/Entity/Bitrix24PartnerReferenceEntityImplementation.php

@@ -30,6 +30,7 @@
 final class Bitrix24PartnerReferenceEntityImplementation implements Bitrix24PartnerInterface, AggregateRootEventsEmitterInterface
 {
     private ?string $comment = null;
+
     private array $events = [];
 
     public function __construct(
@@ -76,10 +77,10 @@ public function setExternalId(?string $externalId): void
         $this->updatedAt = new CarbonImmutable();
 
         $this->events[] = new Bitrix24PartnerExternalIdChangedEvent(
-            $this->getId(),
-            $this->getUpdatedAt(),
+            $this->id,
+            $this->updatedAt,
             $prevExternalId,
-            $this->getExternalId()
+            $this->externalId
         );
     }
 

tests/Unit/Application/Contracts/Bitrix24Partners/Repository/InMemoryBitrix24PartnerRepositoryImplementation.php

@@ -75,7 +75,7 @@ public function findByExternalId(string $externalId, ?Bitrix24PartnerStatus $bit
     {
         $this->logger->debug('b24PartnerRepository.findByExternalId', [
             'externalId' => $externalId,
-            'bitrix24PartnerStatus' => $bitrix24PartnerStatus->name
+            'bitrix24PartnerStatus' => $bitrix24PartnerStatus?->name
         ]);
 
         if (trim($externalId) === '') {

tests/Unit/Application/Contracts/Bitrix24Partners/Repository/InMemoryBitrix24PartnerRepositoryImplementationTest.php

@@ -26,6 +26,7 @@
 use Darsyn\IP\Version\Multi as IP;
 use libphonenumber\PhoneNumber;
 use PHPUnit\Framework\Attributes\CoversClass;
+use Psr\Log\NullLogger;
 use Symfony\Component\Uid\Uuid;
 
 #[CoversClass(Bitrix24PartnerRepositoryInterface::class)]
@@ -60,6 +61,6 @@ protected function createBitrix24PartnerImplementation(
 
     protected function createBitrix24PartnerRepositoryImplementation(): Bitrix24PartnerRepositoryInterface
     {
-        return new InMemoryBitrix24PartnerRepositoryImplementation(Fabric::getLogger());
+        return new InMemoryBitrix24PartnerRepositoryImplementation(new NullLogger());
     }
 }

tests/Unit/Application/Contracts/ContactPersons/Repository/InMemoryContactPersonRepositoryImplementationTest.php

@@ -19,6 +19,7 @@
 use Darsyn\IP\Version\Multi as IP;
 use libphonenumber\PhoneNumber;
 use PHPUnit\Framework\Attributes\CoversClass;
+use Psr\Log\NullLogger;
 use Symfony\Component\Uid\Uuid;
 
 #[CoversClass(ContactPersonRepositoryInterface::class)]
@@ -98,6 +99,6 @@ protected function createContactPersonImplementation(
 
     protected function createContactPersonRepositoryImplementation(): ContactPersonRepositoryInterface
     {
-        return new InMemoryContactPersonRepositoryImplementation(Fabric::getLogger());
+        return new InMemoryContactPersonRepositoryImplementation(new NullLogger());
     }
 }