-
-
Notifications
You must be signed in to change notification settings - Fork 347
WIP: feat: maplibre #3785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WIP: feat: maplibre #3785
Conversation
…tastic#3704) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…vider between read/unread (meshtastic#3693)
…ic#3676) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com> Co-authored-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: b8b8 <156552149+b8b8@users.noreply.github.com> Co-authored-by: James Rich <2199651+jamesarich@users.noreply.github.com>
…meshtastic#3712) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
meshtastic#3718) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…meshtastic#3720) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
…c#3721) Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
3ef2701 to
da06108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
feature/map/src/main/kotlin/org/meshtastic/feature/map/MapLayerItem.kt
Outdated
Show resolved
Hide resolved
feature/map/src/fdroid/kotlin/org/meshtastic/feature/map/maplibre/utils/MapLibreLayerUtils.kt
Show resolved
Hide resolved
feature/map/src/fdroid/kotlin/org/meshtastic/feature/map/component/MapButton.kt
Outdated
Show resolved
Hide resolved
64cf0f9 to
6b4a4ba
Compare
…into poc/maplibre
…into poc/maplibre
…into poc/maplibre
…into poc/maplibre
6b4a4ba to
980578a
Compare
|
Cluster tap behavior is a bit unexpected:
|
|
The introduction of an indication of Also a bit conflicted about showing the nodeid as the identifier/label on the pin, in other places the node is identified by color and shortname (the node chip). |
|
Also as brought up in conversation - we'll need to better understand the demo tileserver usage or if we need to roll our own, etc. |
|
Heatmap.. did not seem functional (or I do not have enough heat 🥶 )... |
Due to the smaller location dots, it would be nice if clustering would stay off when selected as such and between page changes. |
yes, short name would be better. I do like colour coded roles but it is inconsistent withe previous layout so makes sense to use the proper node derived colour. |
Heat map works for me but i personally dont think its needed. If it stays though, that's fine. |
Yes there is, I can do this pretty easily. Will add to todo list.
Will do this as well
I agree that role colors diverge from present UI, however on a node map I do feel like the ability to differentiate role types at a quick glance is very useful. I could add a toggle to cycle between nodeColor and role colors?
As discussed in discord, this is only for emojis and is unfortunately a constraint of MapLibre. I have found a blog post with a potential solution that I can try to implement. If after a few iterations on this and potentially other solutions, I could fall back to node long name instead of hex ID. Would that suffice? Regarding heatmap - very much a WIP that I can remove. It's definitely broken as it lies |


MapLibre has near feature parity with Google Maps and actually has some advantages:
MapLibre Exclusive Features:
Google Maps Exclusive Features
Things that I'm shelving for later (in no particular order):
Will address the missing features in separate PRs. This PR is already way too big, sorry guys