Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant surrounding classbox from lollipop #4037

Closed
mestaritonttu opened this issue Jan 27, 2023 · 2 comments · Fixed by #5880
Closed

Remove redundant surrounding classbox from lollipop #4037

mestaritonttu opened this issue Jan 27, 2023 · 2 comments · Fixed by #5880
Assignees
@jgreywolf @yari-dewalt
Labels
Graph: Class Status: Awaiting PR Type: Bug / Error Something isn't working or is incorrect

Comments

@mestaritonttu
Copy link

Description

This is a continuation of #1145. As mentioned in #3311 there is still a classbox to be removed.

Steps to reproduce

Check the class diagram demos, syntax is Interface1 ()-- Interface1Impl

Screenshots

No response

Code Sample

No response

Setup

No response

Additional Context

No response
@mestaritonttu mestaritonttu added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jan 27, 2023
@tomperr
Copy link
Contributor

tomperr commented Jan 27, 2023

I am a little confused as to what is expected, as I don't really understand what has been done and what is yet to be implemented. Can you please give some explanations? Sorry if I am missing something obvious

@mestaritonttu
Copy link
Author

I am a little confused as to what is expected, as I don't really understand what has been done and what is yet to be implemented. Can you please give some explanations? Sorry if I am missing something obvious

See these examples of how it should look like:

https://www.uml-diagrams.org/realization.html

https://plantuml.com/class-diagram#8b64d7547fa4f699

At the head of the lollipop, there is only text, not a box. So in the Mermaid class diagram section in the demo page, Interface1, Animal and Fruit should not be inside a box.

@jgreywolf jgreywolf self-assigned this Mar 17, 2023
@jgreywolf jgreywolf added Status: Approved Is ready to be worked on and removed Status: Triage Needs to be verified, categorized, etc labels Mar 17, 2023
@jgreywolf jgreywolf added roadmap items to add to roadmap for auto workflow and removed roadmap items to add to roadmap for auto workflow labels Nov 16, 2023
@yari-dewalt yari-dewalt mentioned this issue Sep 24, 2024
Merged
4 tasks
@jgreywolf jgreywolf linked a pull request Sep 25, 2024 that will close this issue
Update class diagram to v3 using new renderer #5880
Merged
4 tasks
@github-actions github-actions bot mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgreywolf jgreywolf

@yari-dewalt yari-dewalt

Labels
Graph: Class Status: Awaiting PR Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update class diagram to v3 using new renderer yari-dewalt/mermaid
4 participants
@jgreywolf @mestaritonttu @tomperr @yari-dewalt