Improve git_remote_connect error handling

A-Ovchinnikov-mx · A-Ovchinnikov-mx · commit c1ae58d1c307 · 2021-09-28T13:47:52.000+02:00
See libgit2/libgit2sharp#1913
diff --git a/LibGit2Sharp/Core/Proxy.cs b/LibGit2Sharp/Core/Proxy.cs
@@ -2154,17 +2154,11 @@ public static unsafe RemoteHandle git_remote_create_anonymous(RepositoryHandle r
 
         public static unsafe void git_remote_connect(RemoteHandle remote, GitDirection direction, ref GitRemoteCallbacks remoteCallbacks, ref GitProxyOptions proxyOptions)
         {
-            GitStrArrayManaged customHeaders = new GitStrArrayManaged();
-
-            try
+            using (var customHeaders = new GitStrArrayManaged())
             {
                 int res = NativeMethods.git_remote_connect(remote, direction, ref remoteCallbacks, ref proxyOptions, ref customHeaders.Array);
                 Ensure.ZeroResult(res);
             }
-            catch (Exception)
-            {
-                customHeaders.Dispose();
-            }
         }
 
         public static unsafe string git_remote_default_branch(RemoteHandle remote)

Original file line number	Diff line number	Diff line change
`@@ -2154,17 +2154,11 @@ public static unsafe RemoteHandle git_remote_create_anonymous(RepositoryHandle r`
`2154`	`2154`
`2155`	`2155`	`public static unsafe void git_remote_connect(RemoteHandle remote, GitDirection direction, ref GitRemoteCallbacks remoteCallbacks, ref GitProxyOptions proxyOptions)`
`2156`	`2156`	`{`
`2157`		`- GitStrArrayManaged customHeaders = new GitStrArrayManaged();`
`2158`		`-`
`2159`		`- try`
	`2157`	`+ using (var customHeaders = new GitStrArrayManaged())`
`2160`	`2158`	`{`
`2161`	`2159`	`int res = NativeMethods.git_remote_connect(remote, direction, ref remoteCallbacks, ref proxyOptions, ref customHeaders.Array);`
`2162`	`2160`	`Ensure.ZeroResult(res);`
`2163`	`2161`	`}`
`2164`		`- catch (Exception)`
`2165`		`- {`
`2166`		`- customHeaders.Dispose();`
`2167`		`- }`
`2168`	`2162`	`}`
`2169`	`2163`
`2170`	`2164`	`public static unsafe string git_remote_default_branch(RemoteHandle remote)`