Check for trace log level before creating the log string.

Author: passalaqua

javasource/databaseconnector/actions/ExecuteParameterizedQuery.java

@@ -73,7 +73,7 @@ public java.util.List<IMendixObject> executeAction() throws Exception
 		IMetaObject metaObject = Core.getMetaObject(this.resultObjectType);
 		List<IMendixObject> resultList = connector.executeQuery(this.jdbcUrl, this.userName, this.password,
 				metaObject, this.sql, this.getContext());
-		logNode.trace(String.format("Result list count: %d", resultList.size()));
+		if (logNode.isTraceEnabled()) logNode.trace(String.format("Result list count: %d", resultList.size()));
 
 		return resultList;
 		// END USER CODE

javasource/databaseconnector/actions/ExecuteQuery.java

@@ -72,7 +72,7 @@ public java.util.List<IMendixObject> executeAction() throws Exception
 		IMetaObject metaObject = resultObject.getMetaObject();
 		List<IMendixObject> resultList = connector.executeQuery(this.jdbcUrl, this.userName, this.password,
 				metaObject, this.sql, this.getContext());
-		logNode.trace(String.format("Result list count: %d", resultList.size()));
+		if (logNode.isTraceEnabled()) logNode.trace(String.format("Result list count: %d", resultList.size()));
 
 		return resultList;
 		// END USER CODE

javasource/databaseconnector/impl/JdbcConnectionManager.java

@@ -45,12 +45,16 @@ public Connection getConnection(final String jdbcUrl, final String userName, fin
 
 		final Integer connPoolKey = toConnPoolKey(jdbcUrl, userName);
 		final HikariDataSource dataSource = connectionPool.computeIfAbsent(connPoolKey, k -> {
-			logNode.trace(
-					String.format("Creating data source in connection pool for [url=%s, user=%s]", jdbcUrl, userName));
+			if (logNode.isTraceEnabled()) {
+				logNode.trace(String.format("Creating data source in connection pool for [url=%s, user=%s]", jdbcUrl, userName));
+			}
 			return createHikariDataSource(jdbcUrl, userName, password, connPoolKey);
 		});
-		logNode.trace(String.format("Getting connection from data source in connection pool for [url=%s, user=%s]",
+
+		if (logNode.isTraceEnabled()) {
+			logNode.trace(String.format("Getting connection from data source in connection pool for [url=%s, user=%s]",
 				jdbcUrl, userName));
+		}
 		return dataSource.getConnection();
 	}
 
@@ -64,10 +68,12 @@ public Connection getConnection(final String jdbcUrl, final String userName, fin
 	private synchronized void initializeDrivers() {
 		if (!hasDriversInitialized) {
 			ServiceLoader<Driver> loader = ServiceLoader.load(Driver.class);
-			Stream<String> driverNames = StreamSupport.stream(loader.spliterator(), false)
-					.map(a -> a.getClass().getName());
-			String logMessage = driverNames.collect(Collectors.joining(", ", "Found JDBC Drivers: ", ""));
-			logNode.trace(logMessage);
+			if (logNode.isTraceEnabled()) {
+				Stream<String> driverNames = StreamSupport.stream(loader.spliterator(), false)
+						.map(a -> a.getClass().getName());
+				String logMessage = driverNames.collect(Collectors.joining(", ", "Found JDBC Drivers: ", ""));
+				logNode.trace(logMessage);
+			}
 			hasDriversInitialized = true;
 		}
 	}

javasource/databaseconnector/impl/JdbcConnector.java

@@ -56,7 +56,7 @@ public JdbcConnector(final ILogNode logNode) {
 
 	public List<IMendixObject> executeQuery(final String jdbcUrl, final String userName, final String password,
 			final IMetaObject metaObject, final String sql, final IContext context) throws SQLException, DatabaseConnectorException {
-		logNode.trace(String.format("executeQuery: %s, %s, %s", jdbcUrl, userName, sql));
+		if (logNode.isTraceEnabled()) logNode.trace(String.format("executeQuery: %s, %s, %s", jdbcUrl, userName, sql));
 
 		try (Connection connection = connectionManager.getConnection(jdbcUrl, userName, password);
 				PreparedStatement preparedStatement = preparedStatementCreator.create(sql, connection);
@@ -68,7 +68,7 @@ public List<IMendixObject> executeQuery(final String jdbcUrl, final String userN
 
 	public List<IMendixObject> executeQuery(final String jdbcUrl, final String userName, final String password,
 			final IMetaObject metaObject, final IStringTemplate sql, final IContext context) throws SQLException, DatabaseConnectorException {
-		logNode.trace(String.format("executeQuery: %s, %s, %s", jdbcUrl, userName, sql));
+		if (logNode.isTraceEnabled()) logNode.trace(String.format("executeQuery: %s, %s, %s", jdbcUrl, userName, sql));
 
 		try (Connection connection = connectionManager.getConnection(jdbcUrl, userName, password);
 				PreparedStatement preparedStatement = preparedStatementCreator.create(sql, connection);
@@ -98,7 +98,7 @@ private IMendixObject createMendixObject(final IContext context,
 		for (Map.Entry<String, Optional<Object>> column : columns.entrySet()) {
 			setMemberValue(context, metaObject, obj, column.getKey(), column.getValue());
 		}
-		logNode.trace("Instantiated object: " + obj);
+		if (logNode.isTraceEnabled()) logNode.trace("Instantiated object: " + obj);
 		return obj;
 	}
 
@@ -131,7 +131,7 @@ private void setMemberValue(IContext context, IMetaObject metaObject, IMendixObj
 
 	public long executeStatement(final String jdbcUrl, final String userName, final String password, final String sql)
 			throws SQLException {
-		logNode.trace(String.format("executeStatement: %s, %s, %s", jdbcUrl, userName, sql));
+		if (logNode.isTraceEnabled()) logNode.trace(String.format("executeStatement: %s, %s, %s", jdbcUrl, userName, sql));
 
 		try (Connection connection = connectionManager.getConnection(jdbcUrl, userName, password);
 				PreparedStatement preparedStatement = preparedStatementCreator.create(sql, connection)) {
@@ -141,7 +141,7 @@ public long executeStatement(final String jdbcUrl, final String userName, final
 
 	public long executeStatement(final String jdbcUrl, final String userName, final String password,
 			final IStringTemplate sql) throws SQLException {
-		logNode.trace(String.format("executeStatement: %s, %s, %s", jdbcUrl, userName, sql));
+		if (logNode.isTraceEnabled()) logNode.trace(String.format("executeStatement: %s, %s, %s", jdbcUrl, userName, sql));
 
 		try (Connection connection = connectionManager.getConnection(jdbcUrl, userName, password);
 				PreparedStatement preparedStatement = preparedStatementCreator.create(sql, connection)) {
@@ -151,7 +151,7 @@ public long executeStatement(final String jdbcUrl, final String userName, final
 
 	public void executeCallableStatement(final String jdbcUrl, final String userName, final String password,
 			final Statement stmt) throws SQLException, DatabaseConnectorException {
-		logNode.trace(String.format("executeCallableStatement: %s, %s, %s", jdbcUrl, userName, stmt.getContent()));
+		if (logNode.isTraceEnabled()) logNode.trace(String.format("executeCallableStatement: %s, %s, %s", jdbcUrl, userName, stmt.getContent()));
 
 		try (Connection connection = connectionManager.getConnection(jdbcUrl, userName, password);
 				StatementWrapper callableStatement = callableStatementCreator.create(stmt, connection)) {