Skip to content

Commit 0f0cc57

Browse files
passalaquapassalaqua
committed
Use ArrayList instead of LinkedList when possible
1 parent 95b1150 commit 0f0cc57

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

‎javasource/databaseconnector/impl/JdbcConnector.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import java.sql.PreparedStatement;
2121
import java.sql.ResultSet;
2222
import java.sql.SQLException;
23-
import java.util.LinkedList;
23+
import java.util.ArrayList;
2424
import java.util.List;
2525
import java.util.Map;
2626
import java.util.Optional;
@@ -84,7 +84,7 @@ private Function<Object, Object> toSuitableValue(final PrimitiveType type) {
8484

8585
private List<IMendixObject> createMendixObjects(final IContext context,
8686
final IMetaObject metaObject, List<Map<String, Optional<Object>>> resultSet) throws DatabaseConnectorException {
87-
List<IMendixObject> convertedResult = new LinkedList<IMendixObject>();
87+
List<IMendixObject> convertedResult = new ArrayList<IMendixObject>();
8888
for (Map<String, Optional<Object>> result : resultSet) {
8989
convertedResult.add(createMendixObject(context, metaObject, result));
9090
}

‎javasource/databaseconnectortest/test/callablestatement/StatementBuilder.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import java.nio.file.Files;
66
import java.nio.file.Path;
77
import java.util.Date;
8-
import java.util.LinkedList;
8+
import java.util.ArrayList;
99
import java.util.List;
1010

1111
import com.mendix.core.Core;
@@ -27,7 +27,7 @@ public class StatementBuilder {
2727
private IContext context;
2828
private Statement statement;
2929

30-
private List<Parameter> parameters = new LinkedList<Parameter>();
30+
private List<Parameter> parameters = new ArrayList<Parameter>();
3131

3232
public StatementBuilder(IContext context, Statement statement) {
3333
this.context = context;

‎javasource/databaseconnectortest/test/callablestatement/TestCallableStatementLists.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import static databaseconnectortest.test.callablestatement.Queries.*;
44
import static org.junit.Assert.assertEquals;
55

6-
import java.util.LinkedList;
6+
import java.util.ArrayList;
77
import java.util.List;
88
import java.util.stream.Collectors;
99
import java.util.stream.Stream;
@@ -188,7 +188,7 @@ public void testInputListOutputLong() throws Exception {
188188
public void testInputEmptyList() throws Exception {
189189
StatementBuilder builder = new StatementBuilder(context);
190190

191-
List<ParameterLong> inputList = new LinkedList<ParameterLong>();
191+
List<ParameterLong> inputList = new ArrayList<ParameterLong>();
192192

193193
builder = builder
194194
.withListInputParameter(1, null, inputList, "ARRAY_6_NUMBERS")

‎javasource/databaseconnectortest/test/callablestatement/TestCallableStatementObjects.java‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import static org.junit.Assert.assertEquals;
77

88
import java.sql.SQLException;
9-
import java.util.LinkedList;
9+
import java.util.ArrayList;
1010
import java.util.List;
1111

1212
import org.junit.Test;
@@ -26,7 +26,7 @@ public class TestCallableStatementObjects extends TestCallableStatementBase {
2626
public void testObjectInput() throws Exception {
2727
StatementBuilder builder = new StatementBuilder(context);
2828

29-
List<Parameter> inputObjectFields = new LinkedList<Parameter>();
29+
List<Parameter> inputObjectFields = new ArrayList<Parameter>();
3030
inputObjectFields.add(builder.stringField(1, TEST_STRING));
3131
inputObjectFields.add(builder.longField(2, AU));
3232

@@ -43,7 +43,7 @@ public void testObjectInput() throws Exception {
4343
public void testObjectInputNulls() throws Exception {
4444
StatementBuilder builder = new StatementBuilder(context);
4545

46-
List<Parameter> inputObjectFields = new LinkedList<Parameter>();
46+
List<Parameter> inputObjectFields = new ArrayList<Parameter>();
4747
inputObjectFields.add(builder.stringField(1, null));
4848
inputObjectFields.add(builder.longField(2, null));
4949

@@ -60,7 +60,7 @@ public void testObjectInputNulls() throws Exception {
6060
public void testObjectInputTooManyMembers() throws Exception {
6161
StatementBuilder builder = new StatementBuilder(context);
6262

63-
List<Parameter> inputObjectFields = new LinkedList<Parameter>();
63+
List<Parameter> inputObjectFields = new ArrayList<Parameter>();
6464
inputObjectFields.add(builder.stringField(1, TEST_STRING));
6565
inputObjectFields.add(builder.longField(2, AU));
6666
inputObjectFields.add(builder.longField(3, AU));
@@ -76,7 +76,7 @@ public void testObjectInputTooManyMembers() throws Exception {
7676
public void testObjectInputTooFewMembers() throws Exception {
7777
StatementBuilder builder = new StatementBuilder(context);
7878

79-
List<Parameter> inputObjectFields = new LinkedList<Parameter>();
79+
List<Parameter> inputObjectFields = new ArrayList<Parameter>();
8080
inputObjectFields.add(builder.stringField(1, TEST_STRING));
8181

8282
builder = builderFromObjectToMembers(builder, inputObjectFields)
@@ -90,7 +90,7 @@ public void testObjectInputTooFewMembers() throws Exception {
9090
public void testObjectInputMixedUpTypes() throws Exception {
9191
StatementBuilder builder = new StatementBuilder(context);
9292

93-
List<Parameter> inputObjectFields = new LinkedList<Parameter>();
93+
List<Parameter> inputObjectFields = new ArrayList<Parameter>();
9494
inputObjectFields.add(builder.longField(1, AU));
9595
inputObjectFields.add(builder.stringField(2, TEST_STRING));
9696

@@ -106,7 +106,7 @@ public void testObjectInputMixedUpTypes() throws Exception {
106106
public void testObjectInputDuplicatePosition() throws Exception {
107107
StatementBuilder builder = new StatementBuilder(context);
108108

109-
List<Parameter> inputObjectFields = new LinkedList<Parameter>();
109+
List<Parameter> inputObjectFields = new ArrayList<Parameter>();
110110
inputObjectFields.add(builder.longField(2, AU));
111111
inputObjectFields.add(builder.stringField(2, TEST_STRING));
112112

@@ -122,7 +122,7 @@ public void testObjectInputDuplicatePosition() throws Exception {
122122
public void testObjectOutput() throws Exception {
123123
StatementBuilder builder = new StatementBuilder(context);
124124

125-
List<Parameter> outputObjectFields = new LinkedList<Parameter>();
125+
List<Parameter> outputObjectFields = new ArrayList<Parameter>();
126126
outputObjectFields.add(builder.stringField(1, null));
127127
outputObjectFields.add(builder.longField(2, null));
128128

@@ -141,7 +141,7 @@ public void testObjectOutput() throws Exception {
141141
public void testObjectOutputNulls() throws Exception {
142142
StatementBuilder builder = new StatementBuilder(context);
143143

144-
List<Parameter> outputObjectFields = new LinkedList<Parameter>();
144+
List<Parameter> outputObjectFields = new ArrayList<Parameter>();
145145
outputObjectFields.add(builder.stringField(1, null));
146146
outputObjectFields.add(builder.longField(2, null));
147147

@@ -163,7 +163,7 @@ public void testObjectOutputNulls() throws Exception {
163163
public void testObjectOutputTooFewParameters() throws Exception {
164164
StatementBuilder builder = new StatementBuilder(context);
165165

166-
List<Parameter> outputObjectFields = new LinkedList<Parameter>();
166+
List<Parameter> outputObjectFields = new ArrayList<Parameter>();
167167
outputObjectFields.add(builder.stringField(1, null));
168168

169169
builder = builderFromMembersToObject(builder, outputObjectFields)
@@ -179,7 +179,7 @@ public void testObjectOutputTooFewParameters() throws Exception {
179179
public void testObjectOutputDuplicateKeys() throws Exception {
180180
StatementBuilder builder = new StatementBuilder(context);
181181

182-
List<Parameter> outputObjectFields = new LinkedList<Parameter>();
182+
List<Parameter> outputObjectFields = new ArrayList<Parameter>();
183183
outputObjectFields.add(builder.stringField(2, null));
184184
outputObjectFields.add(builder.longField(2, null));
185185

@@ -195,7 +195,7 @@ public void testObjectOutputDuplicateKeys() throws Exception {
195195
public void testObjectOutputTooManyParameters() throws Exception {
196196
StatementBuilder builder = new StatementBuilder(context);
197197

198-
List<Parameter> outputObjectFields = new LinkedList<Parameter>();
198+
List<Parameter> outputObjectFields = new ArrayList<Parameter>();
199199
outputObjectFields.add(builder.stringField(1, null));
200200
outputObjectFields.add(builder.longField(2, null));
201201
outputObjectFields.add(builder.longField(3, null));
@@ -212,7 +212,7 @@ public void testObjectOutputTooManyParameters() throws Exception {
212212
public void testObjectOutputMixedUpParameters() throws Exception {
213213
StatementBuilder builder = new StatementBuilder(context);
214214

215-
List<Parameter> outputObjectFields = new LinkedList<Parameter>();
215+
List<Parameter> outputObjectFields = new ArrayList<Parameter>();
216216
outputObjectFields.add(builder.longField(1, null));
217217
outputObjectFields.add(builder.stringField(2, null));
218218

@@ -268,7 +268,7 @@ public void inOutObject() throws Exception {
268268
}
269269

270270
private List<Parameter> objectFields(String name, Long age, StatementBuilder builder) throws Exception {
271-
List<Parameter> objectFields = new LinkedList<Parameter>();
271+
List<Parameter> objectFields = new ArrayList<Parameter>();
272272
objectFields.add(builder.stringField(1, name));
273273
objectFields.add(builder.longField(2, age));
274274
return objectFields;

0 commit comments

Comments
 (0)