Verbose query execution time#36
Merged
Merged
Conversation
jmatak
changed the title
gitbuda
reviewed
Aug 3, 2022
gitbuda
reviewed
Aug 3, 2022
gitbuda
reviewed
Aug 3, 2022
gitbuda
reviewed
Aug 3, 2022
jbajic
suggested changes
Aug 4, 2022
Contributor
jbajic
left a comment
jbajic
left a comment
There was a problem hiding this comment.
Also please add tests, and bump up the mgconsole version
Contributor
Author
|
@jbajic Currently, no tests check additional flags and the full output. Do you think there is a benefit to adding these? Also, how should we test in end-to-end something that is not deterministic like execution time |
Contributor
|
You are right, feel free to ignore the tests, but please bump up
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful information included from #35