Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solid and Clean Code: item-list #358

Closed
2 tasks done
darmsDD opened this issue Nov 25, 2020 · 0 comments
Closed
2 tasks done

Solid and Clean Code: item-list #358

darmsDD opened this issue Nov 25, 2020 · 0 comments

Comments

@darmsDD
Copy link
Contributor

darmsDD commented Nov 25, 2020 •
edited
Loading

Description
Solid and Clean Code issue. I had a hard time undertanding the code in this page(Jandig/src/ARte/users/jinja2/users/components/item-list.jinja2) when doing other issues. I wished it would be clear.

Acceptance criteria
One way is to set variables with code parts of jinja2, and setting the name of the variables in such a way the it's function is clear.

Tasks

  • Create variables.
  • Set self-explanatory name to variables.
@darmsDD darmsDD mentioned this issue Nov 25, 2020
Merged
2 tasks
@darmsDD darmsDD changed the title Clean Code: item-list Solid and Clean Code: item-list Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pablodiegoss @darmsDD