Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an artist, I want to change the size, proportion and position of Objects, so I can create more immersive content #220

Open
vjpixel opened this issue Jun 25, 2019 · 14 comments
Assignees
Labels
bug Something isn't working CMS enhancement New feature or request user
Milestone

Comments

@vjpixel
Copy link
Member

vjpixel commented Jun 25, 2019

Some objects are created as rectangular GIFs. The user needs to be able to correct this on the platform.

@vjpixel
Copy link
Member Author

vjpixel commented Jun 25, 2019

This issue is impacting the exhibition on Sesc right now and will impact the one on EBAC.

@pablodiegoss
Copy link
Member

How do you suggest we solve this? Post an example of the problem here and how you want it to be like

@vjpixel
Copy link
Member Author

vjpixel commented Jun 25, 2019 via email

@vjpixel
Copy link
Member Author

vjpixel commented Jul 10, 2019

I'm adding a screenshot now. Tokusatsu, Robô Rodas, Sexy na Janela, Plan9 and Robô Peixe are with wrong proportions.

Screenshot from 2019-07-10 12-20-38

@vjpixel vjpixel added this to the Launch milestone Sep 21, 2019
@vjpixel
Copy link
Member Author

vjpixel commented Sep 21, 2019

do you need any more information @pablodiegoss ?

@vjpixel vjpixel changed the title 4. change size/proportion of objects 4. change size/proportion/position of objects Sep 21, 2019
@pablodiegoss
Copy link
Member

The thumbnails are set to be shown in 50x50 in this grid. It is just a CSS problem, should work fine inside the app and camera as we use the marker on its real size and do not scale or resize them.

This issue is actually related to be able to edit the position/scale/rotation of an Object being shown on a marker. Like we have coded Samurai being a little bigger than the marker, how do we make a UI to change this params for each marker? Which kind of buttons do we implement for the user to update position/rotation/scale of an object and understand the final result that is happening to his Artwork? Thats our problem.

@vjpixel
Copy link
Member Author

vjpixel commented Oct 4, 2019

I think the best solution to solve this issue in the short term is:

For proportion
To calculate the proportion of the Object based on its resolution, and to fit the shorter side in the marker (so, if the Object is in portrait format, it should fit the sides on the sides on the sides of the marker). There's no user interaction here.

For size
Create a scale numerical field. The default value should be 1, and in this case, it follows the rules above.

For position
Create two numerical fields, Vertical and Horizontal, that allow positive and negative values, and positions the Object in a plane. The default values are 0.

To make easier to understand the settings, we can improve this manual and put this information, including information about to test and come back to change these settings.

@pablodiegoss
Copy link
Member

For size
Create a scale numerical field. The default value should be 1, and in this case, it follows the rules above.

For position
Create two numerical fields, Vertical and Horizontal, that allow positive and negative values, and positions the Object in a plane. The default values are 0.

Both values for scale and position are 3d vectors, since we work in a 3d virtual scene to position objects.
Then we have to ignore scales like (1x, 1.5y ,1z) to have scales of only equal values (1,1,1) if we use this kind of numerical field.
For position then Z would be unused too. Horizontal would change the X and Vertical the Y but a (0,0) would represent the center of a marker or the left upper corner?.

@vjpixel
Copy link
Member Author

vjpixel commented Oct 7, 2019

Using scale and position as you're describing seems to be good.

We should use the center of the marker as (0,0).

@vjpixel vjpixel added the bug Something isn't working label Oct 7, 2019
@vjpixel vjpixel modified the milestones: Launch, Carnival Jan 3, 2020
@anacforcelli anacforcelli self-assigned this Jan 20, 2020
@vjpixel vjpixel added the S label Jan 20, 2020
@vjpixel vjpixel added CMS enhancement New feature or request labels Jan 26, 2020
@vjpixel vjpixel changed the title As an antist, I want to change the size, proportion and position of objects, so I can create more immersive content As an artist, I want to change the size, proportion and position of objects, so I can create more immersive content Jan 29, 2020
@vjpixel vjpixel added XS and removed S labels Feb 1, 2020
@vjpixel
Copy link
Member Author

vjpixel commented Feb 6, 2020

@anacforcelli it still doesn't match the requisites below.

You can have the Scale and Rotation code commented. The scale needs to be calculated automatically, following the rules below.

Also, to solve this issue a user needs to be able to edit the content after it's published, so it can adjust the values until the content is in the desired position.

One solution to do this is to implement an "edit" button on Object list on the My Stuff tab.

Tip: the Z now is the Size described below.

I think the best solution to solve this issue in the short term is:

For proportion
To calculate the proportion of the Object based on its resolution, and to fit the shorter side in the marker (so, if the Object is in portrait format, it should fit the sides on the sides on the sides of the marker). There's no user interaction here.

For size
Create a scale numerical field. The default value should be 1, and in this case, it follows the rules above.

For position
Create two numerical fields, Vertical and Horizontal, that allow positive and negative values, and positions the Object in a plane. The default values are 0.

To make easier to understand the settings, we can improve this manual and put this information, including information about to test and come back to change these settings.

@vjpixel vjpixel changed the title As an artist, I want to change the size, proportion and position of objects, so I can create more immersive content As an artist, I want to change the size, proportion and position of Objects, so I can create more immersive content Feb 6, 2020
@vjpixel vjpixel added S and removed XS labels Feb 10, 2020
@anacforcelli
Copy link
Contributor

Checking the scope:
-Make "help" icons that show a text box near the cursor when the user hovers the mouse over them;
-Objects on item-lists show on scale instead of fixed 50x50;
-Edit an object's attributes after it was uploaded via an edit button that leads to an edit page.

@vjpixel
Copy link
Member Author

vjpixel commented Feb 10, 2020

The objects must have the Height or Width as 50px, and the other side must be smaller. This way, the larger side is 50px.

OK?

@anacforcelli
Copy link
Contributor

yes, that is check

@anacforcelli
Copy link
Contributor

I am doing a teamwork with @hockpond to develop the edit pages for artworks and objects, which also regard issue #307, in such a way that the user won't be prompted to input everything about the artwork/object they are editing again.

@pablodiegoss pablodiegoss removed the S label Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMS enhancement New feature or request user
Projects
None yet
Development

No branches or pull requests

3 participants