Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image crop when turning the smartphone from portrait to landscape #130

Closed
rodrigocam opened this issue Mar 26, 2019 · 11 comments
Closed

Image crop when turning the smartphone from portrait to landscape #130

rodrigocam opened this issue Mar 26, 2019 · 11 comments
Assignees
Labels
AR viewer bug Something isn't working user
Milestone

Comments

@rodrigocam
Copy link
Member

The resize when change the view from portrait to landscape is wrong, cropping the image or distorting

@rodrigocam rodrigocam added the bug Something isn't working label Mar 26, 2019
@rodrigocam
Copy link
Member Author

That issue is being resolved in this PR rodrigocam/ar-gif#11

@pablodiegoss
Copy link
Member

Issue fixed, just waiting for the review on the PR. Apparently already fixes our problems with screen size and rotation

@pablodiegoss
Copy link
Member

Issue solved on the rodrigocam/ar-gif#11, tested on most phones and seems much better

@vjpixel
Copy link
Member

vjpixel commented Jul 17, 2019

It is still cropping the image here (both on Dev and Prod).

Screenshot_20190717-143457_Chrome

@vjpixel vjpixel reopened this Jul 17, 2019
@vjpixel
Copy link
Member

vjpixel commented Sep 21, 2019

@rodrigocam @pablodiegoss do you need any more info to debug this?

@vjpixel vjpixel added this to the Launch milestone Sep 21, 2019
@pablodiegoss
Copy link
Member

Some update to browsers may have broken the solution i created on the mentioned PR. Needs investigation

@vjpixel vjpixel modified the milestones: Launch, Carnival Jan 3, 2020
@anacforcelli anacforcelli self-assigned this Jan 3, 2020
@hockpond
Copy link
Contributor

Maybe this thread on stackoverflow may help: https://stackoverflow.com/questions/3501510/blocking-device-rotation-on-mobile-web-pages

@vjpixel vjpixel added S and removed L labels Feb 10, 2020
@hockpond hockpond removed their assignment Feb 10, 2020
@luccaepp
Copy link
Contributor

When you turns the screen, the app cut the image, it is necessary to disable the screen-rotation in the app for it works only as portrait, avoiding the image cut.

@vjpixel
Copy link
Member

vjpixel commented Feb 10, 2020

Great!

vjpixel added a commit that referenced this issue Feb 13, 2020
@vjpixel
Copy link
Member

vjpixel commented Feb 14, 2020

I've tested on the dev environment and it's asking for camera permission every time I turn the smartphone.

Can you check on that?

@vjpixel
Copy link
Member

vjpixel commented Oct 18, 2020

I've just tested, and it's not asking for camera permissions every time I turn the smartphone anymore.

@vjpixel vjpixel closed this as completed Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AR viewer bug Something isn't working user
Projects
None yet
Development

No branches or pull requests

6 participants