Skip to content

Commit d6cf15c

Browse files
Rename getInterceptors()/setInterceptors() to getFlow/setFlow() (#2186)
* rename interceptor getter and setter to flow * adjust tests * adjust tests * fix name
1 parent 9fbded6 commit d6cf15c

File tree

142 files changed

+366
-369
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

142 files changed

+366
-369
lines changed

core/src/main/java/com/predic8/membrane/core/HttpRouter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ private Transport createTransport() {
4444
interceptors.add(new InternalRoutingInterceptor());
4545
HTTPClientInterceptor httpClientInterceptor = new HTTPClientInterceptor();
4646
interceptors.add(httpClientInterceptor);
47-
transport.setInterceptors(interceptors);
47+
transport.setFlow(interceptors);
4848
return transport;
4949
}
5050

@@ -58,7 +58,7 @@ public HttpTransport getTransport() {
5858
* the list. In tests interceptors in the proxy can be used instead.
5959
*/
6060
public void addUserFeatureInterceptor(Interceptor i) {
61-
List<Interceptor> is = getTransport().getInterceptors();
61+
List<Interceptor> is = getTransport().getFlow();
6262
is.add(is.size()-3, i);
6363
}
6464

core/src/main/java/com/predic8/membrane/core/Router.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,8 @@ public ExecutorService getBackgroundInitializer() {
250250

251251
public Proxy getParentProxy(Interceptor interceptor) {
252252
for (Proxy r : getRuleManager().getRules()) {
253-
if (r.getInterceptors() != null)
254-
for (Interceptor i : r.getInterceptors())
253+
if (r.getFlow() != null)
254+
for (Interceptor i : r.getFlow())
255255
if (i == interceptor)
256256
return r;
257257
}

core/src/main/java/com/predic8/membrane/core/interceptor/AbstractInterceptor.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ public void setDisplayName(String name) {
5757
this.name = name;
5858
}
5959

60-
public void setFlow(EnumSet<Flow> flow) {
60+
public void setAppliedFlow(EnumSet<Flow> flow) {
6161
this.flow = flow;
6262
}
6363

64-
public EnumSet<Flow> getFlow() {
64+
public EnumSet<Flow> getAppliedFlow() {
6565
return flow;
6666
}
6767

@@ -111,17 +111,17 @@ public <T extends Proxy> T getProxy(){
111111
.getRules()
112112
.stream()
113113
.filter(proxy -> proxy
114-
.getInterceptors() != null)
114+
.getFlow() != null)
115115
.filter(proxy -> proxy
116-
.getInterceptors()
116+
.getFlow()
117117
.stream().anyMatch(this::hasSameReferenceAs))
118118
.findAny()
119119
.get();
120120
}
121121

122122
private boolean hasSameReferenceAs(Interceptor i){
123123
if(i instanceof AbstractFlowWithChildrenInterceptor){
124-
return ((AbstractFlowWithChildrenInterceptor) i).getInterceptors().stream().anyMatch(this::hasSameReferenceAs);
124+
return ((AbstractFlowWithChildrenInterceptor) i).getFlow().stream().anyMatch(this::hasSameReferenceAs);
125125
}
126126
return i == this;
127127
}

core/src/main/java/com/predic8/membrane/core/interceptor/DispatchingInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ private String getUri(Exchange exc) throws URISyntaxException {
135135
}
136136

137137
@Override
138-
public EnumSet<Flow> getFlow() {
138+
public EnumSet<Flow> getAppliedFlow() {
139139
return REQUEST_FLOW;
140140
}
141141
}

core/src/main/java/com/predic8/membrane/core/interceptor/ExchangeStoreInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ private void searchAdminConsole() {
133133
for (Proxy r : router.getRuleManager().getRules()) {
134134
if (!(r instanceof AbstractServiceProxy)) continue;
135135

136-
for (Interceptor i : r.getInterceptors()) {
136+
for (Interceptor i : r.getFlow()) {
137137
if (i instanceof AdminConsoleInterceptor) {
138138
serviceProxiesContainingAdminConsole.add((AbstractServiceProxy)r);
139139
}

core/src/main/java/com/predic8/membrane/core/interceptor/HTTPClientInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public class HTTPClientInterceptor extends AbstractInterceptor {
5757

5858
public HTTPClientInterceptor() {
5959
name = "http client";
60-
setFlow(REQUEST_FLOW);
60+
setAppliedFlow(REQUEST_FLOW);
6161
}
6262

6363
@Override

core/src/main/java/com/predic8/membrane/core/interceptor/IndexInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public List<ServiceInfo> getServices(Exchange exc) {
5454
}
5555

5656
private ServiceInfo getServiceInfo(Exchange exc, AbstractServiceProxy sp) {
57-
if (sp.getInterceptors().size() == 1 && sp.getInterceptors().getFirst() instanceof IndexInterceptor)
57+
if (sp.getFlow().size() == 1 && sp.getFlow().getFirst() instanceof IndexInterceptor)
5858
return null;
5959

6060
ServiceProxyKey k = (ServiceProxyKey) sp.getKey();

core/src/main/java/com/predic8/membrane/core/interceptor/Interceptor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ public boolean isAbort() {
7070

7171
Router getRouter();
7272

73-
void setFlow(EnumSet<Flow> flow);
74-
EnumSet<Flow> getFlow();
73+
void setAppliedFlow(EnumSet<Flow> flow);
74+
EnumSet<Flow> getAppliedFlow();
7575

7676
/**
7777
* If interceptor can handle messages in the request flow.

core/src/main/java/com/predic8/membrane/core/interceptor/InternalRoutingInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public Outcome handleResponse(Exchange exc) {
101101
AbstractServiceProxy service = getRuleByDest(exchange);
102102
RuleMatchingInterceptor.assignRule(exchange, service);
103103
updateRequestPath(exchange);
104-
Outcome outcome = callInterceptors(exchange, service.getInterceptors());
104+
Outcome outcome = callInterceptors(exchange, service.getFlow());
105105
exchange.getDestinations().clear();
106106
exchange.getDestinations().add(getTargetAsUri(exchange, service));
107107
if (outcome == ABORT || outcome == RETURN) {

core/src/main/java/com/predic8/membrane/core/interceptor/RuleMatchingInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class RuleMatchingInterceptor extends AbstractInterceptor {
3838

3939
public RuleMatchingInterceptor() {
4040
name = "rule matching interceptor";
41-
setFlow(REQUEST_FLOW);
41+
setAppliedFlow(REQUEST_FLOW);
4242
}
4343

4444
@Override

0 commit comments

Comments
 (0)