Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3 #46

Merged
merged 4 commits into from Sep 9, 2016
Merged

Swift 3 #46

merged 4 commits into from Sep 9, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2016

First, I can't make a branch for you, so this PR should really have a base of some branch you'd create.

It's interesting that this becomes a category on the new Date struct instead of the old NSDate class.
That said it doesn't seem to have changed any behavior that I can see.
Let me know if I can do anything to help.

@mikaelbo
Copy link

mikaelbo commented Aug 4, 2016

It would be great to have an update for Beta4 ^_^

@ghost
Copy link
Author

ghost commented Aug 4, 2016

I'll try to get to that soon

@ghost
Copy link
Author

ghost commented Aug 6, 2016

I've updated for beta 4 @mikaelbo
Had to figure out what the correct new APIs were, and I think I got them all right :D

@mikaelbo
Copy link

mikaelbo commented Aug 8, 2016

@CalQL8ed-K-OS Awesome! I just forked the project and tried to do it myself, but I'm sure there's something I've missed ^_^. I'm not the most experienced with tests, but I thinking about adding some to ensure further "code migrations" feel safer and easier to do :)

@ghost
Copy link
Author

ghost commented Aug 8, 2016

That would be sweet, let me know if you feel you need some help, I'd be happy to assist.

@mikaelbo
Copy link

mikaelbo commented Aug 9, 2016

@CalQL8ed-K-OS Okay, will do! :)

@melvitax melvitax merged commit 76b8d6b into melvitax:master Sep 9, 2016
@ghost
Copy link
Author

ghost commented Sep 9, 2016

You should probably update the readme since this is Swift 3 now

@melvitax
Copy link
Owner

melvitax commented Sep 9, 2016

l'll update right after I fix some of the errors we now have

@melvitax
Copy link
Owner

melvitax commented Sep 9, 2016

Fixed errors, updated version, read me and pod spec. Thanks @CalQL8ed-K-OS and @mikaelbo for porting it. I tried cocoa pods but encountered "Encountered an unknown error (Simulator iPhone 4s is not available.) during validation" which I'm not clear on.

This was referenced Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants