You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When using S3 buckets with KMS SSE turned on for drone-cache, the drone manifest requires explicit definition for S3 endpoint with https schema. This is due to:
KMS SSE backed buckets require secure transport or else they will throw an error: Requests specifying Server Side Encryption with AWS KMS managed keys must be made over a secure connection.
Will set DisableSSL to false, unless endpoint is explicitly defined.
Describe the solution you'd like
I would like to see default SSL on everywhere, and to have explicit configuration in order to disable it. Using default, implicit S3 endpoints should preferred.
Describe alternatives you've considered
There could be an explicit configuration flag to turn on / off SSL.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
When using S3 buckets with KMS SSE turned on for drone-cache, the drone manifest requires explicit definition for S3 endpoint with https schema. This is due to:
Requests specifying Server Side Encryption with AWS KMS managed keys must be made over a secure connection.
drone-cache/storage/backend/s3/s3.go
Line 38 in f32236f
Describe the solution you'd like
I would like to see default SSL on everywhere, and to have explicit configuration in order to disable it. Using default, implicit S3 endpoints should preferred.
Describe alternatives you've considered
There could be an explicit configuration flag to turn on / off SSL.
The text was updated successfully, but these errors were encountered: