Added two new rotation plugins that have more intuitive behavior #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eflynch
changed the title
kamilpiskorski
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was pretty confused by the existing rotation plugin. It makes sense of 90º rotations, but for anything else, it makes a box thats big enough to house the new image but then doesn't render it in the center. I wasn't sure if preserving the behavior of the original is important or not, so my changes add two new rotation plugins. The first, rotateSquareBox, behaves just like the original should (I think) for non 90º rotations, and for 90º rotations keeps the square-box behavior for consistency. The second, rotateBoundingBox, makes a canvas exactly as big as required to house the rotation and no larger, therefore it behaves like the original for 90º rotations and has a more intuitive behavior for other rotations.