This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Auto-batching - Enable feature by default and remove unwanted options #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
commented
Jul 20, 2022
Closed
6 tasks
curquiza
changed the title
curquiza
changed the title
curquiza
force-pushed
the
update-auto-batching
branch
from
f86a2f9 to
048df02
Compare
curquiza
commented
Jul 20, 2022
gmourier
changed the title
|
🚨 Breaking API change detected: Modified (2)
|
|
Updated the specification to map the meilisearch/meilisearch#2676 changes. |
4 tasks
6 tasks
gmourier
added
OpenAPI
gmourier
changed the title
gmourier
reviewed
Sep 29, 2022
Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
gmourier
approved these changes
Oct 3, 2022
gmourier
added
Implemented
gmourier
added a commit
that referenced
this pull request
Oct 3, 2022
…#162) * Update specs according to new auto-batching behavior * update batchUid to make it internal and hidden from a task resource representation * Remove the batchUid mentions from the task API * Update open-api.yaml Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * update future possibilities Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com>
gmourier
added a commit
that referenced
this pull request
Oct 3, 2022
* Bump openapi spec version to v0.29 * Update 0001-script-based-tokenizer.md (#159) Change tokenizer specs to better fit Charabia implementation * Update the geosearch error (#161) Implemented in meilisearch/milli#561 * Auto-batching - Enable feature by default and remove unwanted options (#162) * Update specs according to new auto-batching behavior * update batchUid to make it internal and hidden from a task resource representation * Remove the batchUid mentions from the task API * Update open-api.yaml Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * update future possibilities Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Search API — Filters - Introduce IN and EXISTS and describe filter capabilities in more precisely (#163) * Write a specification for the new (and old) search filters EXISTS IN NOT (new behaviour) != (new behaviour) * Apply suggestions from code review Co-authored-by: Tamo <tamo@meilisearch.com> Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: Tamo <tamo@meilisearch.com> Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Add missing settings object in the task details field of a settingsUpdate task type (#164) * Remove `name` from indexes resource definition (#165) * Misc — Soft deleted documents (Performance optimization) (#168) * create a spec for the soft deleted documents * Rename spec file, minor adjustements * Replace You and We by A user and Meilisearch Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> * Add Stats Seen event (#169) * Add examples component for each summarized task type (#170) * Version API — Catch up (#171) * Add version-api.md * Add PR number as a spec file prefix * Add health-api.md (#172) * Search API — Add `matchingStrategy` parameter with `last` / `all` strategies (#173) * Introduce a proposal to boot the specification * Update telemetry * Replace wordMatchingStrategy by matchingStrategy * fix missing backtick md Co-authored-by: Many the fish <legendre.maxime.isn@gmail.com> Co-authored-by: Tamo <tamo@meilisearch.com> Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com> Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com> Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
13 tasks
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 API Diff
Summary
Following meilisearch/meilisearch#2582
Enables auto batching by default and removes unnecessary options.
Changes
--enable-auto-batchingflag being removed and replaced by--disable-auto-batching. An environment variable should also be added to handle this option (MEILI_DISABLE_AUTO_BATCHING)--debounce-duration-sec,--max-batch-sizeand--max-documents-per-batch.batchUidfield in task object; It's now an internal field not being displayed.Out Of Scope
N/A
Attention To Reviewers
N/A
Misc
OpenApilabel)Telemetrylabel)