Add SettingsUpdater service #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
force-pushed
the
settings-updater
branch
2 times, most recently
from
a9b19ba to
ee7f5f5
Compare
|
ping @brunoocasali |
|
@norkunas I'll take a look at it today! |
norkunas
force-pushed
the
settings-updater
branch
2 times, most recently
from
4799700 to
ee8bb58
Compare
norkunas
force-pushed
the
settings-updater
branch
from
ee8bb58 to
d11eb9e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
============================================
+ Coverage 86.19% 86.69% +0.50%
Complexity 1 1
============================================
Files 15 19 +4
Lines 768 812 +44
============================================
+ Hits 662 704 +42
- Misses 106 108 +2 ☔ View full report in Codecov by Sentry. |
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Feb 16, 2024
318: Proximity precision r=norkunas a=norkunas # Pull Request ## Related issue Fixes #<issue_number> ## What does this PR do? - Adds support for proximity precision setting ## PR checklist Please check if your PR fulfills the following requirements: - [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? I've based this PR on #317 so will rebase if/after it is merged to get rid of the first commit and also meilisearch/meilisearch-php#606 should be merged first Co-authored-by: Tomas <norkunas.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
meilisearch:createandmeilisearch:importcommands;--update-settingsoption inmeilisearch:importcommand and for consistency also added tomeilisearch:create;Note: to avoid BC break, because settings were always updated, I've changed
update-settingsoption tonegatablemode, so basically running command without it is like passing--update-settingsto command and to allow skipping settings update there is now--no-settings-updateoption automatically added and handled by Symfony.PR checklist
Please check if your PR fulfills the following requirements: