Skip to content

Fix using distinct attribute setting #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #273

What does this PR do?

  • Fixes updating distinct attribute setting and allows to set it as a string instead of an array

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Temporary fix until we'll provide proper configuration schema for each setting separately.

@norkunas norkunas requested a review from brunoocasali October 13, 2023 04:07
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to keep the backwards compatibility (even if that didn't work 😅)

Thanks @norkunas 🎉

bors merge

@norkunas norkunas closed this Oct 16, 2023
@meili-bors meili-bors bot merged commit 411c953 into meilisearch:main Oct 16, 2023
@norkunas norkunas deleted the fix-using-distinct-attribute branch October 16, 2023 18:04
@brunoocasali brunoocasali added the bug Something isn't working label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting: "distinctAttribute" type inconsistency
2 participants