Skip to content

Use modern structure #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

Use modern structure #224

merged 1 commit into from
Jan 17, 2023

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Jan 17, 2023 •
edited
Loading

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Moves Resources/config dir to /config.

See https://symfony.com/doc/current/bundles.html#bundle-directory-structure

Also updated tests namespace as the IDE warned: Namespace name doesn't match the PSR-0/PSR-4 project structure and it's also recommended in the given link.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@brunoocasali brunoocasali added the enhancement New feature or request label Jan 17, 2023
@brunoocasali
Copy link
Member

Hi @norkunas thanks a lot for your time!

Two questions:

Does this represent a breaking change for the users (or should they do anything on their side to use it)? I believe not, but just confirming.

And, how can we automate this type of "alert"?

@brunoocasali brunoocasali self-requested a review January 17, 2023 19:52
@norkunas
Copy link
Collaborator Author

Hi @norkunas thanks a lot for your time!

Two questions:

Does this represent a breaking change for the users (or should they do anything on their side to use it)? I believe not, but just confirming.

And, how can we automate this type of "alert"?

No breaking changes unless people includes bundle config somewhere else, but they shouldn't :)

Not sure what you are asking about automation 🤔

@brunoocasali
Copy link
Member

Not sure what you are asking about automation 🤔

I mean, in as an Action in CI...

@norkunas
Copy link
Collaborator Author

It would just waste CI resources I think, as it is one time change

brunoocasali
brunoocasali approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@norkunas thanks for your time, you rocks! 🤘

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

Build succeeded:

@bors bors bot merged commit 672c1aa into meilisearch:main Jan 17, 2023
@norkunas norkunas deleted the structure branch January 18, 2023 04:13
@brunoocasali brunoocasali mentioned this pull request Feb 7, 2023
Merged
bors bot added a commit that referenced this pull request Feb 8, 2023
@bors @meili-bot @brunoocasali
Merge #226
94f3b0e 
226: Release v0.10.1 r=brunoocasali a=brunoocasali

This version makes this package compatible with Meilisearch v1.0.0 🎉
Check out the changelog of [Meilisearch v1.0.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.0.0) for more information on the changes.

## 🚀 Enhancements

* CI: test with Symfony 6.2 (#223) `@norkunas`
* Use modern structure (#224) `@norkunas`
* Update meilisearch-php to v1.0.0 (#225) `@brunoocasali` 

Thanks again to  `@brunoocasali` and `@norkunas!` 🎉


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norkunas @brunoocasali