Add finite pagination support #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
brunoocasali
commented
Mar 6, 2023
brunoocasali
commented
- Fix some linting issues introduced in the previous PRs.
- Update code-samples (new PR)
brunoocasali
added
enhancement
alallema
approved these changes
Mar 7, 2023
|
|
||
| /// Time, in milliseconds, to process the query. | ||
| public let processingTimeMs: Int? | ||
| // This override is required since swift does not parse all the new keys automatically. |
There was a problem hiding this comment.
It didn't do it before? I thought the Codable was for that
There was a problem hiding this comment.
It does. The issue here is the inheritance from another class. Swift can't handle that :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.